From: Rob Herring <robh@kernel.org>
To: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
Mark Rutland <Mark.Rutland@arm.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"maxime.ripard@bootlin.com" <maxime.ripard@bootlin.com>,
"Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
"Yiqi Kang (Arm Technology China)" <Yiqi.Kang@arm.com>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"Tiannan Zhu (Arm Technology China)" <Tiannan.Zhu@arm.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"airlied@linux.ie" <airlied@linux.ie>,
"malidp@foss.arm.com" <malidp@foss.arm.com>,
"thomas Sun (Arm Technology China)" <thomas.Sun@arm.com>,
Ayan Halder <Ayan.Halder@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"Jin Gao (Arm Technology China)" <Jin.Gao@arm.com>,
nd <nd@arm.com>, "sean@poorly.run" <sean@poorly.run>,
"Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v4 2/9] dt/bindings: drm/komeda: Add DT bindings for ARM display processor D71
Date: Fri, 11 Jan 2019 10:15:27 -0600 [thread overview]
Message-ID: <20190111161527.GA9669@bogus> (raw)
In-Reply-To: <20190103113841.15403-3-james.qian.wang@arm.com>
On Thu, Jan 03, 2019 at 11:40:04AM +0000, james qian wang (Arm Technology China) wrote:
> From: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
>
> Add DT bindings documentation for the ARM display processor D71 and later
> IPs.
>
> Changes in v4:
> - Deleted unnecessary address-cells, size-cells [Liviu Dudau]
>
> Changes in v3:
> - Deleted unnecessary property: interrupt-names.
> - Dropped 'ports' and moving 'port' up a level.
>
> Signed-off-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
> .../bindings/display/arm/arm,komeda.txt | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/arm/arm,komeda.txt
>
> diff --git a/Documentation/devicetree/bindings/display/arm/arm,komeda.txt b/Documentation/devicetree/bindings/display/arm/arm,komeda.txt
> new file mode 100644
> index 000000000000..919d651d3e8c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/arm/arm,komeda.txt
> @@ -0,0 +1,73 @@
> +Device Tree bindings for Arm Komeda display driver
> +
> +Required properties:
> +- compatible: Should be "arm,mali-d71"
> +- reg: Physical base address and length of the registers in the system
> +- interrupts: the interrupt line number of the device in the system
> +- clocks: A list of phandle + clock-specifier pairs, one for each entry
> + in 'clock-names'
> +- clock-names: A list of clock names. It should contain:
> + - "mclk": for the main processor clock
> + - "pclk": for the APB interface clock
> +- #address-cells: Must be 1
> +- #size-cells: Must be 0
> +
> +Required properties for sub-node: pipeline@nq
> +Each device contains one or two pipeline sub-nodes (at least one), each
> +pipeline node should provide properties:
> +- reg: Zero-indexed identifier for the pipeline
> +- clocks: A list of phandle + clock-specifier pairs, one for each entry
> + in 'clock-names'
> +- clock-names: should contain:
> + - "pxclk": pixel clock
> + - "aclk": AXI interface clock
> +
> +- port: each pipeline connect to an encoder input port. The connection is
> + modeled using the OF graph bindings specified in
> + Documentation/devicetree/bindings/graph.txt
> +
> +Optional properties:
> + - memory-region: phandle to a node describing memory (see
> + Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
> + to be used for the framebuffer; if not present, the framebuffer may
> + be located anywhere in memory.
> +
> +Example:
> +/ {
> + ...
> +
> + dp0: display@c00000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "arm,mali-d71";
> + reg = <0xc00000 0x20000>;
> + interrupts = <0 168 4>;
> + clocks = <&dpu_mclk>, <&dpu_aclk>;
> + clock-names = "mclk", "pclk";
> +
> + dp0_pipe0: pipeline@0 {
> + clocks = <&fpgaosc2>, <&dpu_aclk>;
> + clock-names = "pxclk", "aclk";
> + reg = <0>;
> +
> + port@0 {
Drop the '@0'
> + dp0_pipe0_out: endpoint {
> + remote-endpoint = <&db_dvi0_in>;
> + };
> + };
> + };
> +
> + dp0_pipe1: pipeline@1 {
> + clocks = <&fpgaosc2>, <&dpu_aclk>;
> + clock-names = "pxclk", "aclk";
> + reg = <1>;
> +
> + port@0 {
And here.
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
> + dp0_pipe1_out: endpoint {
> + remote-endpoint = <&db_dvi1_in>;
> + };
> + };
> + };
> + };
> + ...
> +};
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-11 16:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 11:39 [PATCH v4 0/9] Overview of Arm komeda display driver james qian wang (Arm Technology China)
2019-01-03 11:39 ` [PATCH v4 1/9] drm/komeda: komeda_dev/pipeline/component definition and initialzation james qian wang (Arm Technology China)
2019-01-03 11:40 ` [PATCH v4 2/9] dt/bindings: drm/komeda: Add DT bindings for ARM display processor D71 james qian wang (Arm Technology China)
2019-01-11 16:15 ` Rob Herring [this message]
2019-01-03 11:40 ` [PATCH v4 3/9] drm/komeda: Build komeda to be a platform module james qian wang (Arm Technology China)
2019-01-03 11:40 ` [PATCH v4 4/9] drm/komeda: Add DT parsing james qian wang (Arm Technology China)
2019-01-03 11:40 ` [PATCH v4 5/9] drm/komeda: Add komeda_format_caps for format handling james qian wang (Arm Technology China)
2019-01-03 11:41 ` [PATCH v4 6/9] drm/komeda: Add komeda_framebuffer james qian wang (Arm Technology China)
2019-01-03 11:41 ` [PATCH v4 7/9] drm/komeda: Attach komeda_dev to DRM-KMS james qian wang (Arm Technology China)
2019-01-03 11:41 ` [PATCH v4 8/9] drm/doc: Add initial komeda driver documentation james qian wang (Arm Technology China)
2019-01-03 11:42 ` [PATCH v4 9/9] MAINTAINERS: Add maintainer for Arm komeda driver james qian wang (Arm Technology China)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111161527.GA9669@bogus \
--to=robh@kernel.org \
--cc=Alexandru-Cosmin.Gheorghe@arm.com \
--cc=Ayan.Halder@arm.com \
--cc=Jin.Gao@arm.com \
--cc=Jonathan.Chai@arm.com \
--cc=Julien.Yin@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lowry.Li@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Tiannan.Zhu@arm.com \
--cc=Yiqi.Kang@arm.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.qian.wang@arm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malidp@foss.arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab+samsung@kernel.org \
--cc=nd@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=rdunlap@infradead.org \
--cc=sean@poorly.run \
--cc=thomas.Sun@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).