From: Borislav Petkov <bp@alien8.de>
To: Faiz Abbas <faiz_abbas@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
ulf.hansson@linaro.org, adrian.hunter@intel.com,
j-keerthy@ti.com, edubezval@gmail.com, olof@lixom.net
Subject: Re: [PATCH] mmc: Fix Kconfig warnings on keystone_defconfig
Date: Sat, 12 Jan 2019 22:12:42 +0100 [thread overview]
Message-ID: <20190112211242.GA4512@zn.tnic> (raw)
In-Reply-To: <20190109124312.10154-1-faiz_abbas@ti.com>
On Wed, Jan 09, 2019 at 06:13:12PM +0530, Faiz Abbas wrote:
> Commit 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding
> SDR104/HS200 tuning failures (i929)") added a select on TI_SOC_THERMAL
> for the driver to get temperature for tuning.
>
> However, this causes the following warning on keystone_defconfig because
> keystone does not support TI_SOC_THERMAL:
>
> "WARNING: unmet direct dependencies detected for TI_SOC_THERMAL"
>
> Fix this by changing the select to imply.
>
> Fixes: 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding
> SDR104/HS200 tuning failures (i929)")
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index e26b8145efb3..bc61eefcb695 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -978,7 +978,7 @@ config MMC_SDHCI_OMAP
> tristate "TI SDHCI Controller Support"
> depends on MMC_SDHCI_PLTFM && OF
> select THERMAL
> - select TI_SOC_THERMAL
> + imply TI_SOC_THERMAL
> help
> This selects the Secure Digital Host Controller Interface (SDHCI)
> support present in TI's DRA7 SOCs. The controller supports
> --
Fixes the warnings I'm seeing with randconfig builds.
Tested-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-01-12 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 12:43 [PATCH] mmc: Fix Kconfig warnings on keystone_defconfig Faiz Abbas
2019-01-12 21:12 ` Borislav Petkov [this message]
2019-01-14 8:31 ` Adrian Hunter
2019-01-14 11:44 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190112211242.GA4512@zn.tnic \
--to=bp@alien8.de \
--cc=adrian.hunter@intel.com \
--cc=edubezval@gmail.com \
--cc=faiz_abbas@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).