From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] sysrq: Remove duplicated sysrq message
Date: Mon, 14 Jan 2019 14:51:27 +0900 [thread overview]
Message-ID: <20190114055127.GB7417@jagdpanzerIV> (raw)
In-Reply-To: <20190111162038.19771-3-pmladek@suse.com>
On (01/11/19 17:20), Petr Mladek wrote:
> The commit 97f5f0cd8cd0a0544 ("Input: implement SysRq as a separate input
> handler") added pr_fmt() definition. It caused a duplicated message
> prefix in the sysrq header messages, for example:
>
> [ 177.053931] sysrq: SysRq : Show backtrace of all active CPUs
> [ 742.864776] sysrq: SysRq : HELP : loglevel(0-9) reboot(b) crash(c)
>
> Fixes: 97f5f0cd8cd0a05 ("Input: implement SysRq as a separate input handler")
> Signed-off-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
A side note:
> - pr_cont("This sysrq operation is disabled.\n");
> + pr_info("This sysrq operation is disabled.\n");
I wouldn't mind this messages to become more informative.
+ pr_info("sysrq 0x%x operation is disabled.\n", key);
?
A bunch of "This sysrq operation is disabled" in serial0 log file
(post mortem) is not very helpful.
-ss
next prev parent reply other threads:[~2019-01-14 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 16:20 [PATCH 0/3] sysrq: Simple fixes and console visibility Petr Mladek
2019-01-11 16:20 ` [PATCH 1/3] sysrq: Restore original console_loglevel when sysrq disabled Petr Mladek
2019-01-11 16:20 ` [PATCH 2/3] sysrq: Remove duplicated sysrq message Petr Mladek
2019-01-14 5:51 ` Sergey Senozhatsky [this message]
2019-01-14 14:45 ` Petr Mladek
2019-01-11 16:20 ` [RFC 3/3] sysrq: Warn about insufficient console_loglevel Petr Mladek
2019-01-14 8:05 ` Sergey Senozhatsky
2019-01-14 14:59 ` Petr Mladek
2019-01-15 3:03 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114055127.GB7417@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).