From: Johan Hovold <johan@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Johan Hovold <johan@kernel.org>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>
Subject: Re: [PATCH v2 5/5] dt-bindings: gnss: add lna-supply property
Date: Mon, 14 Jan 2019 10:15:17 +0100 [thread overview]
Message-ID: <20190114091517.GD3691@localhost> (raw)
In-Reply-To: <20190110180732.75490757@kemnade.info>
On Thu, Jan 10, 2019 at 06:07:32PM +0100, Andreas Kemnade wrote:
> On Thu, 10 Jan 2019 13:27:57 +0100
> Johan Hovold <johan@kernel.org> wrote:
>
> > On Sun, Dec 09, 2018 at 08:51:50PM +0100, Andreas Kemnade wrote:
> > > Add lna-supply property.
> > >
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > ---
> > > Changes in v2:
> > > - reordering
> > > Original order had a
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > >
> > > Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > Ah, missed this one at first.
> >
> > But shouldn't this go into the generic binding since it isn't specific
> > for sirf-star based receivers?
>
> That idea was formulated with a question mark towards Rob.
> And no reaction from Rob about that.
Right, maybe that suggestion wasn't very clear.
But since this property is not specific to sirf-star based devices, it
needs to go in the generic binding.
Thanks,
Johan
prev parent reply other threads:[~2019-01-14 9:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 19:51 [PATCH v2 0/5] gnss: sirf: add support for w2sg0004 + lna Andreas Kemnade
2018-12-09 19:51 ` [PATCH v2 1/5] gnss: sirf: write data to gnss only when the gnss device is open Andreas Kemnade
2019-01-10 12:02 ` Johan Hovold
2019-01-13 20:50 ` Andreas Kemnade
2019-01-14 12:00 ` Johan Hovold
2018-12-09 19:51 ` [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal Andreas Kemnade
2019-01-10 12:10 ` Johan Hovold
2019-01-10 22:02 ` Andreas Kemnade
2019-01-14 10:51 ` Johan Hovold
2019-01-14 12:13 ` Andreas Kemnade
2019-01-22 8:38 ` Johan Hovold
2019-01-14 21:58 ` Andreas Kemnade
2019-01-15 9:08 ` Johan Hovold
2018-12-09 19:51 ` [PATCH v2 3/5] dt-bindings: gnss: add w2sg0004 compatible string Andreas Kemnade
2019-01-10 12:12 ` Johan Hovold
2018-12-09 19:51 ` [PATCH v2 4/5] gnss: sirf: add a separate supply for a lna Andreas Kemnade
2018-12-10 7:42 ` [Letux-kernel] " H. Nikolaus Schaller
2019-01-10 12:25 ` Johan Hovold
2018-12-09 19:51 ` [PATCH v2 5/5] dt-bindings: gnss: add lna-supply property Andreas Kemnade
2019-01-10 12:27 ` Johan Hovold
2019-01-10 17:07 ` Andreas Kemnade
2019-01-14 9:15 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114091517.GD3691@localhost \
--to=johan@kernel.org \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).