From: Anders Roxell <anders.roxell@linaro.org>
To: thierry.reding@gmail.com
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Anders Roxell <anders.roxell@linaro.org>
Subject: [PATCH] pwm: imx27: fix build issue
Date: Mon, 14 Jan 2019 12:14:35 +0100 [thread overview]
Message-ID: <20190114111435.27397-1-anders.roxell@linaro.org> (raw)
When PWM_IMX27 was configured as a module we got the following
build error:
In file included from ../drivers/pwm/pwm-imx27.c:15:
../drivers/pwm/pwm-imx27.c:292:25: error: ‘imx_pwm_dt_ids’
undeclared here (not in a function); did you mean ‘pwm_imx27_dt_ids’?
MODULE_DEVICE_TABLE(of, imx_pwm_dt_ids);
^~~~~~~~~~~~~~
../include/linux/module.h:213:15: note: in definition of macro ‘MODULE_DEVICE_TABLE’
extern typeof(name) __mod_##type##__##name##_device_table \
^~~~
../include/linux/module.h:213:21: error: ‘__mod_of__imx_pwm_dt_ids_device_table’
aliased to undefined symbol ‘imx_pwm_dt_ids’
extern typeof(name) __mod_##type##__##name##_device_table \
^~~~~~
../drivers/pwm/pwm-imx27.c:292:1: note: in expansion of macro ‘MODULE_DEVICE_TABLE’
MODULE_DEVICE_TABLE(of, imx_pwm_dt_ids);
^~~~~~~~~~~~~~~~~~~
Rework to use the new variable name pwm_imx27_dt_ids.
Fixes: 5a309d380019 ("pwm: imx: Split into two drivers")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/pwm/pwm-imx27.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
index 8997c4c1bd03..55666cca4cee 100644
--- a/drivers/pwm/pwm-imx27.c
+++ b/drivers/pwm/pwm-imx27.c
@@ -289,7 +289,7 @@ static const struct of_device_id pwm_imx27_dt_ids[] = {
{ .compatible = "fsl,imx27-pwm", },
{ /* sentinel */ }
};
-MODULE_DEVICE_TABLE(of, imx_pwm_dt_ids);
+MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
static int pwm_imx27_probe(struct platform_device *pdev)
{
--
2.19.2
reply other threads:[~2019-01-14 11:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114111435.27397-1-anders.roxell@linaro.org \
--to=anders.roxell@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).