From: Nishanth Menon <nm@ti.com>
To: Faiz Abbas <faiz_abbas@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <mark.rutland@arm.com>,
<robh+dt@kernel.org>, <t-kristo@ti.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC support
Date: Tue, 15 Jan 2019 08:28:54 -0600 [thread overview]
Message-ID: <20190115142854.xbfep5by73oi3sxd@kahuna> (raw)
In-Reply-To: <20190110073355.3382-3-faiz_abbas@ti.com>
Similar problem here as well.. $subject probably needs to be explicit
about eMMC?
On 13:03-20190110, Faiz Abbas wrote:
> On the am654x-evm, the sdhci0 node is connected to an eMMC. Add node and
> pinmux for the same.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index e41fc3a5987b..11e9a2a43dfc 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -69,6 +69,23 @@
> AM65X_IOPAD(0x01bc, PIN_OUTPUT, 0) /* (AG13) SPI0_CS0 */
> >;
> };
> +
> + main_mmc0_pins_default: main-mmc0-pins-default {
> + pinctrl-single,pins = <
> + AM65X_IOPAD(0x01a8, PIN_INPUT_PULLDOWN, 0) /* (B25) MMC0_CLK */
> + AM65X_IOPAD(0x01ac, PIN_INPUT_PULLUP, 0) /* (B27) MMC0_CMD */
> + AM65X_IOPAD(0x01a4, PIN_INPUT_PULLUP, 0) /* (A26) MMC0_DAT0 */
> + AM65X_IOPAD(0x01a0, PIN_INPUT_PULLUP, 0) /* (E25) MMC0_DAT1 */
> + AM65X_IOPAD(0x019c, PIN_INPUT_PULLUP, 0) /* (C26) MMC0_DAT2 */
> + AM65X_IOPAD(0x0198, PIN_INPUT_PULLUP, 0) /* (A25) MMC0_DAT3 */
> + AM65X_IOPAD(0x0194, PIN_INPUT_PULLUP, 0) /* (E24) MMC0_DAT4 */
> + AM65X_IOPAD(0x0190, PIN_INPUT_PULLUP, 0) /* (A24) MMC0_DAT5 */
> + AM65X_IOPAD(0x018c, PIN_INPUT_PULLUP, 0) /* (B26) MMC0_DAT6 */
> + AM65X_IOPAD(0x0188, PIN_INPUT_PULLUP, 0) /* (D25) MMC0_DAT7 */
> + AM65X_IOPAD(0x01b4, PIN_INPUT_PULLUP, 0) /* (A23) MMC0_SDCD */
> + AM65X_IOPAD(0x01b0, PIN_INPUT, 0) /* (C25) MMC0_DS */
> + >;
> + };
> };
>
> &main_pmx1 {
> @@ -163,3 +180,11 @@
> #size-cells= <1>;
> };
> };
> +
> +&sdhci0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&main_mmc0_pins_default>;
> + bus-width = <8>;
> + non-removable;
> + ti,driver-strength-ohm = <50>;
> +};
> --
> 2.19.2
>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2019-01-15 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 7:33 [PATCH v2 0/2] Support for eMMC in AM65x-evm Faiz Abbas
2019-01-10 7:33 ` [PATCH v2 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD Faiz Abbas
2019-01-15 14:27 ` Nishanth Menon
2019-01-10 7:33 ` [PATCH v2 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC support Faiz Abbas
2019-01-15 14:28 ` Nishanth Menon [this message]
2019-01-15 14:29 ` [PATCH v2 0/2] Support for eMMC in AM65x-evm Nishanth Menon
2019-01-17 9:05 ` Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115142854.xbfep5by73oi3sxd@kahuna \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).