From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCE15C43387 for ; Tue, 15 Jan 2019 16:59:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91B8920645 for ; Tue, 15 Jan 2019 16:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547571546; bh=VqwcoxuwVNJxyFs/mLhqSXcPs76mtFO/PCs+w7wvE/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=x7CdX+rw+O+ehBKDg5TB9L7ggm/7RdFMw9Nd25ATKQap0g0orQDXyljhcwhrXcukK RKiOqGKKwNuicbA1kSrTF9RShCqSKz4LOoC5vpW8u4t0XymxWk4PdJGx/sBUHVoWr4 oj/16ge/hcek5sxsPzCElvN1wKQ4GH6LljnZBJWg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388167AbfAOQ7F (ORCPT ); Tue, 15 Jan 2019 11:59:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:55734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732346AbfAOQje (ORCPT ); Tue, 15 Jan 2019 11:39:34 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6BF220859; Tue, 15 Jan 2019 16:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547570374; bh=VqwcoxuwVNJxyFs/mLhqSXcPs76mtFO/PCs+w7wvE/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IYblhUtt9QlwWyc0Fd5CUb3fNhfKf38jakJ9KfUdGhRBSeoKeOWLvLlcLISYahi3J P01htl325hbYwR++is6WyKRgwVKbZPG/OO2R2eM7oNTBPGRIKtaS1eQOsS9yJbiwzV zWfr8yx9nIq+T/nePf6tBgShyBveX7cp4cj/uHRg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavel Shilovsky , Jeff Layton , Steve French Subject: [PATCH 4.9 02/16] CIFS: Do not hide EINTR after sending network packets Date: Tue, 15 Jan 2019 17:35:45 +0100 Message-Id: <20190115154848.370685096@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190115154848.164648613@linuxfoundation.org> References: <20190115154848.164648613@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pavel Shilovsky commit ee13919c2e8d1f904e035ad4b4239029a8994131 upstream. Currently we hide EINTR code returned from sock_sendmsg() and return 0 instead. This makes a caller think that we successfully completed the network operation which is not true. Fix this by properly returning EINTR to callers. Cc: Signed-off-by: Pavel Shilovsky Reviewed-by: Jeff Layton Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/cifs/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -301,7 +301,7 @@ uncork: if (rc < 0 && rc != -EINTR) cifs_dbg(VFS, "Error %d sending data on socket to server\n", rc); - else + else if (rc > 0) rc = 0; return rc;