linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: George Hilliard <thirtythreeforty@gmail.com>
Cc: devel@driverdev.osuosl.org, NeilBrown <neil@brown.name>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: Mediatek: Use individual config flags in Makefile
Date: Tue, 15 Jan 2019 18:43:46 +0100	[thread overview]
Message-ID: <20190115174346.GA11832@kroah.com> (raw)
In-Reply-To: <20190115172916.26937-1-thirtythreeforty@gmail.com>

On Tue, Jan 15, 2019 at 10:29:18AM -0700, George Hilliard wrote:
> These drivers can be useful on other MT76xx SoCs, which have compatible
> peripherals.  The drivers were selectable in Kconfig, but they were
> quietly excluded from the build because the SOC_MT7621 chip was not
> selected.  So, make the Makefiles use the same flags as Kconfig for
> these drivers.
> 
> mt7621-dma and mt7621-dts are left alone because they truly do require
> that SoC.
> 
> I have personally confirmed that the mt7621-spi driver works on the
> MT7688, which was what prompted this change.
> 
> Cc: linux-kernel@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Cc: NeilBrown <neil@brown.name>
> Cc: sergio.paracuellos@gmail.com
> Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
> ---
> Changes in v2..v4:
>   - Also use individual flags for mt7621-pci and the new mt7621-pci-phy
>   - Slightly revise commit message

You also rebased this patch, right?

Anyway, applying this patch, I get the following build error:

  CC [M]  drivers/staging/mt7621-mmc/sd.o
  CC [M]  drivers/staging/mt7621-mmc/dbg.o
drivers/staging/mt7621-mmc/sd.c:48:10: fatal error: asm/mach-ralink/ralink_regs.h: No such file or directory
 #include <asm/mach-ralink/ralink_regs.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [scripts/Makefile.build:277: drivers/staging/mt7621-mmc/sd.o] Error 1
make[3]: *** Waiting for unfinished jobs....
drivers/staging/mt7621-mmc/dbg.c: In function ‘msdc_debug_proc_write’:
drivers/staging/mt7621-mmc/dbg.c:237:12: warning: unused variable ‘size’ [-Wunused-variable]
  int mode, size;
            ^~~~
drivers/staging/mt7621-mmc/dbg.c:237:6: warning: unused variable ‘mode’ [-Wunused-variable]
  int mode, size;
      ^~~~
make[2]: *** [scripts/Makefile.build:492: drivers/staging/mt7621-mmc] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [scripts/Makefile.build:492: drivers/staging] Error 2
make[1]: *** Waiting for unfinished jobs....

So I can't take this patch as is, sorry.

Please fix.

thanks,

greg k-h

  reply	other threads:[~2019-01-15 17:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CACmrr9gHucWaWtz07kQms6AsquLKAHbK+_Q0kF=92RGo6HmAFA@mail.gmail.com>
2019-01-11  0:43 ` [PATCH v2 1/2] Move ralink-gdma to its own directory thirtythreeforty
2019-01-11  0:43   ` [PATCH v2 2/2] Mediatek staging: Use individual config flags in Makefile thirtythreeforty
2019-01-15 15:30     ` [PATCH v2 2/2] staging: Mediatek: " Greg Kroah-Hartman
2019-01-15 17:02       ` [PATCH v3] " George Hilliard
2019-01-15 17:20         ` Greg Kroah-Hartman
2019-01-15 17:29           ` [PATCH v4] " George Hilliard
2019-01-15 17:43             ` Greg Kroah-Hartman [this message]
2019-01-16  6:48               ` [PATCH v5] " George Hilliard
2019-01-16  4:43             ` [PATCH v4] " kbuild test robot
2019-01-15 17:32           ` [PATCH v3] " George Hilliard
2019-01-11  1:21   ` [PATCH v2 1/2] Move ralink-gdma to its own directory NeilBrown
2019-01-11  2:13     ` George Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190115174346.GA11832@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=thirtythreeforty@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).