From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, u9012063@gmail.com
Subject: Re: [PATCH net] erspan: build the header with the right proto according to erspan_ver
Date: Wed, 16 Jan 2019 13:37:26 -0800 (PST) [thread overview]
Message-ID: <20190116.133726.2036063241420588039.davem@davemloft.net> (raw)
In-Reply-To: <ae6a0efc813739ab1f9179f2ec8036285193dba9.1547460606.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 14 Jan 2019 18:10:06 +0800
> As said in draft-foschiano-erspan-03#section4:
>
> Different frame variants known as "ERSPAN Types" can be
> distinguished based on the GRE "Protocol Type" field value: Type I
> and II's value is 0x88BE while Type III's is 0x22EB [ETYPES].
>
> So set it properly in erspan_xmit() according to erspan_ver. While at
> it, also remove the unused parameter 'proto' in erspan_fb_xmit().
>
> Fixes: 94d7d8f29287 ("ip6_gre: add erspan v2 support")
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2019-01-16 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 10:10 [PATCH net] erspan: build the header with the right proto according to erspan_ver Xin Long
2019-01-16 21:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116.133726.2036063241420588039.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).