From: Joerg Roedel <jroedel@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Joerg Roedel <joro@8bytes.org>, Jason Wang <jasowang@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, jfehlig@suse.com,
jon.grimm@amd.com, brijesh.singh@amd.com
Subject: Re: [PATCH 3/3] virtio-blk: Consider dma_max_mapping_size() for maximum segment size
Date: Wed, 16 Jan 2019 15:10:43 +0100 [thread overview]
Message-ID: <20190116141043.qbsdbdt72akxpdtj@suse.de> (raw)
In-Reply-To: <20190116090355-mutt-send-email-mst@kernel.org>
On Wed, Jan 16, 2019 at 09:05:40AM -0500, Michael S. Tsirkin wrote:
> On Tue, Jan 15, 2019 at 02:22:57PM +0100, Joerg Roedel wrote:
> > + max_size = dma_max_mapping_size(&vdev->dev);
> > +
>
>
> Should this be limited to ACCESS_PLATFORM?
>
> I see no reason to limit this without as guest can
> access any memory.
Actually, yes. This should be inside a use_dma_api check. I had it in
v1, but it went away without the vring layer for propagating the limit.
I'll add that again.
Thanks,
Joerg
prev parent reply other threads:[~2019-01-16 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 13:22 [PATCH 0/3 v2] Fix virtio-blk issue with SWIOTLB Joerg Roedel
2019-01-15 13:22 ` [PATCH 1/3] swiotlb: Introduce swiotlb_max_mapping_size() Joerg Roedel
2019-01-15 13:22 ` [PATCH 2/3] dma: Introduce dma_max_mapping_size() Joerg Roedel
2019-01-15 13:37 ` Christoph Hellwig
2019-01-15 16:23 ` Joerg Roedel
2019-01-15 17:54 ` Christoph Hellwig
2019-01-15 13:22 ` [PATCH 3/3] virtio-blk: Consider dma_max_mapping_size() for maximum segment size Joerg Roedel
2019-01-16 14:05 ` Michael S. Tsirkin
2019-01-16 14:10 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116141043.qbsdbdt72akxpdtj@suse.de \
--to=jroedel@suse.de \
--cc=axboe@kernel.dk \
--cc=brijesh.singh@amd.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=jfehlig@suse.com \
--cc=jon.grimm@amd.com \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).