From: Martin Lau <kafai@fb.com>
To: Mathieu Malaterre <malat@debian.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpf: Make function btf_name_offset_valid static
Date: Wed, 16 Jan 2019 21:16:29 +0000 [thread overview]
Message-ID: <20190116211627.bs3rrolbjdsxkyvp@kafai-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20190116192940.32104-1-malat@debian.org>
On Wed, Jan 16, 2019 at 08:29:40PM +0100, Mathieu Malaterre wrote:
> Initially in commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format
> (BTF)") the function 'btf_name_offset_valid' was introduced as static
> function it was later on changed to a non-static one, and then finally
> in commit c454a46b5efd ("bpf: Add bpf_line_info support") the function
> prototype was removed.
Instead of c454a46b5efd, it was removed from btf.h in
commit 23127b33ec80 ("bpf: Create a new btf_name_by_offset() for non type name use case")
>
> Revert back to original implementation and make the function static.
> Remove warning triggered with W=1:
>
> kernel/bpf/btf.c:470:6: warning: no previous prototype for 'btf_name_offset_valid' [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Fixes: 23127b33ec80 ("bpf: Create a new btf_name_by_offset() for non type name use case")
Thanks for the fix!
Other than the above,
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2019-01-16 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 19:29 [PATCH] bpf: Make function btf_name_offset_valid static Mathieu Malaterre
2019-01-16 21:16 ` Martin Lau [this message]
2019-01-17 15:56 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116211627.bs3rrolbjdsxkyvp@kafai-mbp.dhcp.thefacebook.com \
--to=kafai@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=malat@debian.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).