* [PATCH] sb1000: fix a couple of indentation issues
@ 2019-01-17 0:13 Colin King
2019-01-17 0:20 ` Joe Perches
2019-01-18 5:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-01-17 0:13 UTC (permalink / raw)
To: David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is an if statement and a return statement that are incorrectly
indented. Fix these.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/sb1000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
index 7820fced33f6..af4838124f8c 100644
--- a/drivers/net/sb1000.c
+++ b/drivers/net/sb1000.c
@@ -540,12 +540,12 @@ sb1000_activate(const int ioaddr[], const char* name)
if ((status = card_send_command(ioaddr, name, Command1, st)))
return status;
if (st[3] != 0xf1) {
- if ((status = sb1000_start_get_set_command(ioaddr, name)))
+ if ((status = sb1000_start_get_set_command(ioaddr, name)))
return status;
return -EIO;
}
udelay(1000);
- return sb1000_start_get_set_command(ioaddr, name);
+ return sb1000_start_get_set_command(ioaddr, name);
}
/* get SB1000 firmware version */
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sb1000: fix a couple of indentation issues
2019-01-17 0:13 [PATCH] sb1000: fix a couple of indentation issues Colin King
@ 2019-01-17 0:20 ` Joe Perches
2019-01-18 5:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2019-01-17 0:20 UTC (permalink / raw)
To: Colin King, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
On Thu, 2019-01-17 at 00:13 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an if statement and a return statement that are incorrectly
> indented. Fix these.
[]
> diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
[]
> @@ -540,12 +540,12 @@ sb1000_activate(const int ioaddr[], const char* name)
> if ((status = card_send_command(ioaddr, name, Command1, st)))
> return status;
> if (st[3] != 0xf1) {
> - if ((status = sb1000_start_get_set_command(ioaddr, name)))
> + if ((status = sb1000_start_get_set_command(ioaddr, name)))
Probably better to remove the assignment in the if at the same time.
status = sb1000_start_get_set_command(ioaddr, name);
if (status)
> return status;
> return -EIO;
> }
> udelay(1000);
> - return sb1000_start_get_set_command(ioaddr, name);
> + return sb1000_start_get_set_command(ioaddr, name);
> }
>
> /* get SB1000 firmware version */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sb1000: fix a couple of indentation issues
2019-01-17 0:13 [PATCH] sb1000: fix a couple of indentation issues Colin King
2019-01-17 0:20 ` Joe Perches
@ 2019-01-18 5:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-18 5:52 UTC (permalink / raw)
To: colin.king; +Cc: netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 17 Jan 2019 00:13:01 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an if statement and a return statement that are incorrectly
> indented. Fix these.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-18 5:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 0:13 [PATCH] sb1000: fix a couple of indentation issues Colin King
2019-01-17 0:20 ` Joe Perches
2019-01-18 5:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).