From: Lee Jones <lee.jones@linaro.org>
To: Christian Hohnstaedt <Christian.Hohnstaedt@wago.com>
Cc: Keerthy <j-keerthy@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 2/2] mfd: tps65218.c: Add input voltage options
Date: Thu, 17 Jan 2019 08:07:43 +0000 [thread overview]
Message-ID: <20190117080743.GI23399@dell> (raw)
In-Reply-To: <20190117055436.GA4213@wago.com>
On Thu, 17 Jan 2019, Christian Hohnstaedt wrote:
> On Wed, Jan 16, 2019 at 02:13:36PM +0000, Lee Jones wrote:
> > On Mon, 14 Jan 2019, Christian Hohnstaedt wrote:
> >
> > > These options apply to all regulators in this chip.
> > >
> > > ti,strict-supply-voltage-supervision:
> > > Set STRICT flag in CONFIG1
> > > ti,under-voltage-limit-microvolt:
> > > Select 2.75, 2.95, 3.25 or 3.35 V UVLO in CONFIG1
> > > ti,under-voltage-hyst-microvolt:
> > > Select 200mV or 400mV UVLOHYS in CONFIG2
> > >
> > > Signed-off-by: Christian Hohnstaedt <Christian.Hohnstaedt@wago.com>
> > > Tested-by: Keerthy <j-keerthy@ti.com>
> > > Reviewed-by: Keerthy <j-keerthy@ti.com>
> > > ---
> > > drivers/mfd/tps65218.c | 89 ++++++++++++++++++++++++++++++++++++++++++++
> > > include/linux/mfd/tps65218.h | 4 ++
> > > 2 files changed, 93 insertions(+)
> >
> > This looks like regulator code.
> >
> > Why aren't you placing it into the regulator driver?
>
> This code manages properties of the chip, affecting all regulators.
>
> The regulator-driver has no hook to be called once for the chip.
> Even if I put this code into the regulator driver file,
> I will have to call it from here.
>
> This would introduce a dependency from the mfd to the regulator code.
Sounds reasonable. Thanks for the explanation.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-01-17 8:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 8:05 [PATCH 0/2] Add input voltage configuration for TPS65218 Christian Hohnstaedt
2018-12-18 8:05 ` [PATCH 1/2] dt-bindings: regulator: extend tps65218 bindings Christian Hohnstaedt
2018-12-24 9:15 ` J, KEERTHY
2018-12-28 22:51 ` Rob Herring
2018-12-18 8:05 ` [PATCH 2/2] mfd: tps65218.c: Add input voltage options Christian Hohnstaedt
2018-12-21 11:01 ` Lee Jones
2018-12-23 16:40 ` Tony Lindgren
2018-12-24 6:32 ` Lee Jones
2018-12-24 9:01 ` J, KEERTHY
2018-12-24 9:38 ` J, KEERTHY
2019-01-03 13:47 ` [PATCH v2 0/2] Add input voltage configuration for TPS65218 Christian Hohnstaedt
2019-01-14 8:16 ` [PATCH v3 " Christian Hohnstaedt
2019-01-14 8:16 ` [PATCH v3 1/2] dt-bindings: regulator: extend tps65218 bindings Christian Hohnstaedt
2019-01-14 8:16 ` [PATCH v3 2/2] mfd: tps65218.c: Add input voltage options Christian Hohnstaedt
2019-01-16 14:13 ` Lee Jones
2019-01-17 5:54 ` Christian Hohnstaedt
2019-01-17 8:07 ` Lee Jones [this message]
2019-01-17 8:08 ` Lee Jones
2019-01-03 13:47 ` [PATCH v2 1/2] dt-bindings: regulator: extend tps65218 bindings Christian Hohnstaedt
2019-01-11 16:17 ` Rob Herring
2019-01-03 13:47 ` [PATCH v2 2/2] mfd: tps65218.c: Add input voltage options Christian Hohnstaedt
2019-01-14 6:38 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117080743.GI23399@dell \
--to=lee.jones@linaro.org \
--cc=Christian.Hohnstaedt@wago.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).