From: Brian Masney <masneyb@onstation.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org,
Guenter Roeck <groeck@chromium.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>,
Stephen Boyd <sboyd@kernel.org>,
Doug Anderson <dianders@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] watchdog: qcom: Add suspend/resume support
Date: Thu, 17 Jan 2019 04:31:13 -0500 [thread overview]
Message-ID: <20190117093113.GA23389@basecamp> (raw)
In-Reply-To: <20190117091555.2018-1-saiprakash.ranjan@codeaurora.org>
On Thu, Jan 17, 2019 at 02:45:55PM +0530, Sai Prakash Ranjan wrote:
> +#ifdef CONFIG_PM_SLEEP
> +static int qcom_wdt_suspend(struct device *dev)
> +{
> + struct qcom_wdt *wdt = dev_get_drvdata(dev);
> +
> + if (watchdog_active(&wdt->wdd))
> + qcom_wdt_stop(&wdt->wdd);
> +
> + return 0;
> +}
> +
> +static int qcom_wdt_resume(struct device *dev)
> +{
> + struct qcom_wdt *wdt = dev_get_drvdata(dev);
> +
> + if (watchdog_active(&wdt->wdd))
> + qcom_wdt_start(&wdt->wdd);
> +
> + return 0;
> +}
> +#endif /* CONFIG_PM_SLEEP */
You can use the __maybe_unused attribute to remove the #ifdef:
static int __maybe_unused qcom_wdt_suspend(struct device *dev)
Brian
next prev parent reply other threads:[~2019-01-17 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:15 [PATCH] watchdog: qcom: Add suspend/resume support Sai Prakash Ranjan
2019-01-17 9:31 ` Brian Masney [this message]
2019-01-17 10:38 ` Sai Prakash Ranjan
2019-01-17 11:27 ` Brian Masney
2019-01-17 13:00 ` Sai Prakash Ranjan
2019-01-17 14:30 ` Guenter Roeck
2019-01-17 15:07 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117093113.GA23389@basecamp \
--to=masneyb@onstation.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rnayak@codeaurora.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).