From: Christoph Hellwig <hch@infradead.org>
To: David Kozub <zub@linux.fjfi.cvut.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>, Scott Bauer <scott.bauer@intel.com>,
Jonathan Derrick <jonathan.derrick@intel.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Subject: Re: [PATCH 00/16] block: sed-opal: support shadow MBR done flag and write
Date: Thu, 17 Jan 2019 07:22:20 -0800 [thread overview]
Message-ID: <20190117152220.GC20359@infradead.org> (raw)
In-Reply-To: <alpine.LRH.2.21.1901171030320.26315@linux.fjfi.cvut.cz>
On Thu, Jan 17, 2019 at 10:40:49AM +0100, David Kozub wrote:
> On Thu, 17 Jan 2019, Christoph Hellwig wrote:
>
> > the way the series appear looks odd, because it wasn't threaded or
> > even ordered, and the patches from Jonas seem to have been sent out
> > by you under his name. Can you resend them carefully threaded, all
> > mails from you with the additional from header for resends?
>
> Ouch. I'm sorry about the ordering/threading. I (wrongly) assumed that if I
> just send the mails in order, that suffices. I'll try to fix that in v2.
>
> W.r.t. "from": Most of the patches were originally created by Jonas. I
> touched some in order to apply review suggestions or make some small fixes.
> But some stayed identical to Jonas' version and I didn't want to strip him
> of authorship. I used git format-patch to produce the mails and the commit
> author was propagated to the from header.
>
> What is the proper way when I am not the author?
Send the actual mail as from you, and put another From: line for
the original author into the mail body as the first non-empty line.
next prev parent reply other threads:[~2019-01-17 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 21:56 [PATCH 00/16] block: sed-opal: support shadow MBR done flag and write David Kozub
2019-01-17 8:57 ` Christoph Hellwig
2019-01-17 9:40 ` David Kozub
2019-01-17 15:22 ` Christoph Hellwig [this message]
2019-01-17 21:13 Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117152220.GC20359@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jonas.rabenstein@studium.uni-erlangen.de \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.bauer@intel.com \
--cc=zub@linux.fjfi.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).