From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE6CC43387 for ; Thu, 17 Jan 2019 19:41:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8997320855 for ; Thu, 17 Jan 2019 19:41:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728853AbfAQTlR (ORCPT ); Thu, 17 Jan 2019 14:41:17 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:39491 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728173AbfAQTlQ (ORCPT ); Thu, 17 Jan 2019 14:41:16 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gkDXI-0006Bl-5w; Thu, 17 Jan 2019 20:41:08 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1gkDXH-0003j5-4o; Thu, 17 Jan 2019 20:41:07 +0100 Date: Thu, 17 Jan 2019 20:41:07 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Matthias Brugger Cc: Ryder Lee , Thierry Reding , Sean Wang , Weijie Gao , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 3/5] arm64: dts: mt7622: add a property "mediatek,num-pwms" for PWM Message-ID: <20190117194107.wrafykdre5tugv4q@pengutronix.de> References: <0c400cb1899c1afb4c9f021350cdc0c6ca3f6239.1547453586.git.ryder.lee@mediatek.com> <20190115200231.drn2rbxu4jxr22yz@pengutronix.de> <2edcc5fd-ce60-b585-e0fd-226897a7a34c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2edcc5fd-ce60-b585-e0fd-226897a7a34c@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Jan 17, 2019 at 02:00:43PM +0100, Matthias Brugger wrote: > On 15/01/2019 21:02, Uwe Kleine-König wrote: > > On Mon, Jan 14, 2019 at 04:21:22PM +0800, Ryder Lee wrote: > >> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > >> index 8fc4aa7..ab016cf 100644 > >> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > >> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > >> @@ -436,6 +436,7 @@ > >> <&pericfg CLK_PERI_PWM6_PD>; > >> clock-names = "top", "main", "pwm1", "pwm2", "pwm3", "pwm4", > >> "pwm5", "pwm6"; > >> + mediatek,num-pwms = <6>; > >> status = "disabled"; > > > > Conceptually this patch must go in before the change to the driver. > > Otherwise the pwms are not usable with only patch 1 applied which breaks > > bisectability. > > > > The driver should have backwards compatibility to older DTs. So that would need > to be fixed in the driver not in the patch order of the series. Right you are. Bisectability is a reason to not apply the patches in the order as is, but given that you already requested backwards compatibility the bisectability will be fixed en passant. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |