From: Hugo Lefeuvre <hle@owl.eu.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, "Todd Kjos" <tkjos@android.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Greg Hartman" <ghartman@google.com>,
linux-kernel@vger.kernel.org, "Arve Hjønnevåg" <arve@android.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Martijn Coenen" <maco@android.com>,
"Alistair Strachan" <strachan@google.com>,
"Christian Brauner" <christian@brauner.io>
Subject: Re: [PATCH] sched/wait: introduce wait_event_freezable_hrtimeout
Date: Fri, 18 Jan 2019 08:48:37 +0100 [thread overview]
Message-ID: <20190118074837.GA6288@hle-laptop.local> (raw)
In-Reply-To: <20190118071752.GG11050@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]
Hi Greg,
> > introduce wait_event_freezable_hrtimeout, an interruptible and freezable
> > version of wait_event_hrtimeout.
> >
> > simplify handle_vsoc_cond_wait (drivers/staging/android/vsoc.c) using this
> > newly added helper and remove useless includes.
> >
> > Signed-off-by: Hugo Lefeuvre <hle@owl.eu.com>
> > ---
> > drivers/staging/android/vsoc.c | 69 +++++-----------------------------
> > include/linux/wait.h | 25 ++++++++++--
>
> code in drivers/staging/ should be self-contained, and not, if at all
> possible, ever force additional changes on "core" kernel code.
>
> Are you sure that the vsoc code can't use one of the current wait
> macros?
As far as I know there is no macro implementing freezable wait with high
resolution timeout.
> Why is it so special and unique that no one else in the kernel
> has ever needed this before it came along?
many wait_event_X() (_exclusive, _interruptible, _timeout) functions have a
freezable counterpart. wait_event_hrtimeout() doesn't, probably because it
is relatively new (and seemingly quite unused).
If there is a wait_event_hrtimeout() function, it makes sense to me to have
wait_event_freezable_hrtimeout().
--
Hugo Lefeuvre (hle) | www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-18 7:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 22:41 [PATCH] sched/wait: introduce wait_event_freezable_hrtimeout Hugo Lefeuvre
2019-01-18 7:17 ` Greg Kroah-Hartman
2019-01-18 7:48 ` Hugo Lefeuvre [this message]
2019-01-18 15:19 ` Joel Fernandes
2019-01-18 16:04 ` Peter Zijlstra
2019-01-21 12:01 ` Rafael J. Wysocki
2019-01-18 17:08 ` Hugo Lefeuvre
2019-01-19 1:53 ` Joel Fernandes
2019-01-19 10:29 ` Hugo Lefeuvre
2019-01-22 22:20 ` Joel Fernandes
2019-02-01 5:43 ` Hugo Lefeuvre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118074837.GA6288@hle-laptop.local \
--to=hle@owl.eu.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=ghartman@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=strachan@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).