From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF277C43387 for ; Fri, 18 Jan 2019 08:16:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7F632086D for ; Fri, 18 Jan 2019 08:16:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727610AbfARIQN (ORCPT ); Fri, 18 Jan 2019 03:16:13 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:41605 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727350AbfARIQM (ORCPT ); Fri, 18 Jan 2019 03:16:12 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id ED63E80716; Fri, 18 Jan 2019 09:16:03 +0100 (CET) Date: Fri, 18 Jan 2019 09:16:09 +0100 From: Pavel Machek To: "Edgecombe, Rick P" Cc: "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "ard.biesheuvel@linaro.org" , "Dock, Deneen T" , "linux-integrity@vger.kernel.org" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "nadav.amit@gmail.com" , "dave.hansen@linux.intel.com" , "linux-security-module@vger.kernel.org" , "x86@kernel.org" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "kristen@linux.intel.com" , "mingo@redhat.com" , "linux_dti@icloud.com" , "luto@kernel.org" , "will.deacon@arm.com" , "bp@alien8.de" , "kernel-hardening@lists.openwall.com" , "rjw@rjwysocki.net" Subject: Re: [PATCH 14/17] mm: Make hibernate handle unmapped pages Message-ID: <20190118081609.GA10712@amd> References: <20190117003259.23141-1-rick.p.edgecombe@intel.com> <20190117003259.23141-15-rick.p.edgecombe@intel.com> <20190117093950.GA17930@amd> <20190117234111.GA27661@amd> <3c12f9b3328ee32d04a6ed3990fdf0cd3cb27532.camel@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: <3c12f9b3328ee32d04a6ed3990fdf0cd3cb27532.camel@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2019-01-17 23:48:30, Edgecombe, Rick P wrote: > On Fri, 2019-01-18 at 00:41 +0100, Pavel Machek wrote: > > Hi! > >=20 > > > > > For architectures with CONFIG_ARCH_HAS_SET_ALIAS, pages can be un= mapped > > > > > briefly on the directmap, even when CONFIG_DEBUG_PAGEALLOC is not > > > > > configured. > > > > > So this changes kernel_map_pages and kernel_page_present to be de= fined > > > > > when > > > > > CONFIG_ARCH_HAS_SET_ALIAS is defined as well. It also changes pla= ces > > > > > (page_alloc.c) where those functions are assumed to only be imple= mented > > > > > when > > > > > CONFIG_DEBUG_PAGEALLOC is defined. > > > >=20 > > > > Which architectures are that? > > > >=20 > > > > Should this be merged to the patch where HAS_SET_ALIAS is introduce= d? We > > > > don't want broken hibernation in between.... > > >=20 > > > Thanks for taking a look. It was added for x86 for patch 13 in this p= atchset > > > and > > > there was interest expressed for adding for arm64. If you didn't get = the > > > whole > > > set and want to see let me know and I can send it. > >=20 > > I googled in in the meantime. > >=20 > > Anyway, if something is broken between patch 13 and 14, then they > > should be same patch. > Great. It should be ok because the new functions are not used anywhere un= til > after this patch. Ok, that makes sense. Acked-by: Pavel Machek Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --17pEHd4RhPHOinZp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlxBi0kACgkQMOfwapXb+vKV/QCdFLyEDo+ouJctFO52d/hTAxAP oF0AoIpc7mH97WDF7SfB+pCr3f0ec1vR =niXa -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp--