From: Sudeep Holla <sudeep.holla@arm.com>
To: Pramod Kumar <pramod.kumar@broadcom.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Suzuki K Poulose <Suzuki.Poulose@arm.com>,
Dave Martin <dave.martin@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Steve Capper <steve.capper@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported
Date: Fri, 18 Jan 2019 11:32:42 +0000 [thread overview]
Message-ID: <20190118113242.GA8928@e107155-lin> (raw)
In-Reply-To: <1547790380-6276-1-git-send-email-pramod.kumar@broadcom.com>
On Fri, Jan 18, 2019 at 11:16:20AM +0530, Pramod Kumar wrote:
> If CPU hotplug is supported, ipi_cpu_stop should use PSCI cpudie
> call to stop the CPU. This call ensures L1/L2 cache flush,
> CPUs cache-cohenrecy setting w.r.to interconnect.
>
Firstly, this is not specific to PSCI and I don't see any PSCI calls as
$subject claims. Next, you fail to explain why do you have to ensure
caches are cleaned and why do you need that in ipi_cpu_stop ?
What's the use case ?
> Apart from this, this gives control to f/w to reduce power consumption
> by take appropriate decesion on power rails for plugging-out core.
>
May be, but ipi_cpu_stop is used is machine reboot/poweroff/halt which
may restart or poweroff the system, powering down individual CPUs is not
necessary and may consume lot of time in systems with large number of CPUs.
It would be good to know the use-case in case I am missing to consider
that.
--
Regards,
Sudeep
next prev parent reply other threads:[~2019-01-18 11:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 5:46 [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported Pramod Kumar
2019-01-18 11:32 ` Sudeep Holla [this message]
[not found] ` <CAJ+tv6+6yqT1xkmkY3x6SNQ83K+J6zqKZr7PV5A_ffvyEzceqg@mail.gmail.com>
[not found] ` <CAJ+tv6KqynSf5t_VwLqpdM4BF+wLWcJ0wPTD4nWqL4ej1Yih4g@mail.gmail.com>
2019-01-21 6:06 ` Pramod Kumar
2019-01-23 16:48 ` Mark Rutland
2019-01-23 17:05 ` Scott Branden
2019-01-23 17:21 ` Sudeep Holla
2019-01-23 17:33 ` Scott Branden
2019-01-23 17:33 ` Mark Rutland
2019-01-23 17:46 ` Scott Branden
2019-01-23 18:07 ` Sudeep Holla
2019-01-25 7:03 ` Pramod Kumar
2019-01-25 15:56 ` Robin Murphy
2019-01-25 16:52 ` Sudeep Holla
2019-01-21 11:22 ` Sudeep Holla
2019-01-23 4:51 ` Pramod Kumar
2019-01-23 16:27 ` Sudeep Holla
2019-01-23 16:56 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118113242.GA8928@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=dave.martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=pramod.kumar@broadcom.com \
--cc=robh@kernel.org \
--cc=steve.capper@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).