From: Dave Young <dyoung@redhat.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Kairui Song <kasong@redhat.com>,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
dwmw2@infradead.org, jwboyer@fedoraproject.org,
keyrings@vger.kernel.org, jmorris@namei.org, serge@hallyn.com,
bauerman@linux.ibm.com, ebiggers@google.com, nayna@linux.ibm.com,
linux-integrity@vger.kernel.org, kexec@lists.infradead.org
Subject: Re: [PATCH v4 0/2] let kexec_file_load use platform keyring to verify the kernel image
Date: Fri, 18 Jan 2019 20:34:37 +0800 [thread overview]
Message-ID: <20190118123437.GA30929@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <1547812432.3982.55.camel@linux.ibm.com>
On 01/18/19 at 06:53am, Mimi Zohar wrote:
> On Fri, 2019-01-18 at 17:17 +0800, Kairui Song wrote:
> > This patch series adds a .platform_trusted_keys in system_keyring as the
> > reference to .platform keyring in integrity subsystem, when platform
> > keyring is being initialized it will be updated. So other component could
> > use this keyring as well.
>
> Kairui, when people review patches, the comments could be specific,
> but are normally generic. My review included a couple of generic
> suggestions - not to use "#ifdef" in C code (eg. is_enabled), use the
> term "preboot" keys, and remove any references to "other components".
>
> After all the wording suggestions I've made, you are still saying, "So
> other components could use this keyring as well". Really?! How the
> platform keyring will be used in the future, is up to you and others
> to convince Linus. At least for now, please limit its usage to
> verifying the PE signed kernel image. If this patch set needs to be
> reposted, please remove all references to "other components".
>
> Dave/David, are you ok with Kairui's usage of "#ifdef's"? Dave, you
> Acked the original post. Can I include it? Can we get some
> additional Ack's on these patches?
It is better to update patch to use IS_ENABLED in patch 1/2 as well.
Other than that, for kexec part I'm fine with an ack.
Thanks
Dave
next prev parent reply other threads:[~2019-01-18 12:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 9:17 [PATCH v4 0/2] let kexec_file_load use platform keyring to verify the kernel image Kairui Song
2019-01-18 9:17 ` [PATCH v4 1/2] integrity, KEYS: add a reference to platform keyring Kairui Song
2019-01-18 14:35 ` Nayna
2019-01-18 15:01 ` Kairui Song
2019-01-18 9:17 ` [PATCH v4 2/2] kexec, KEYS: Make use of platform keyring for signature verify Kairui Song
2019-01-18 11:53 ` [PATCH v4 0/2] let kexec_file_load use platform keyring to verify the kernel image Mimi Zohar
2019-01-18 12:07 ` Kairui Song
2019-01-18 12:34 ` Dave Young [this message]
2019-01-18 12:37 ` Dave Young
2019-01-18 13:42 ` Kairui Song
2019-01-18 14:28 ` Kairui Song
2019-01-21 9:08 ` Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118123437.GA30929@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=bauerman@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=ebiggers@google.com \
--cc=jmorris@namei.org \
--cc=jwboyer@fedoraproject.org \
--cc=kasong@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).