From: LEROY Christophe <christophe.leroy@c-s.fr>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Mike Rapoport <rppt@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK
Date: Sat, 19 Jan 2019 18:21:13 +0100 [thread overview]
Message-ID: <20190119182113.Horde.DK6jqX3cEzsvR0fKFZrY2g4@messagerie.si.c-s.fr> (raw)
In-Reply-To: <87zhrx2bf1.fsf@concordia.ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> a écrit :
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>
>> The purpose of this serie is to activate CONFIG_THREAD_INFO_IN_TASK which
>> moves the thread_info into task_struct.
>>
>> Moving thread_info into task_struct has the following advantages:
>> - It protects thread_info from corruption in the case of stack
>> overflows.
>> - Its address is harder to determine if stack addresses are
>> leaked, making a number of attacks more difficult.
>>
>> Changes since v12:
>> - Patch 1: Taken comment from Mike (re-introduced the 'panic' in
>> case memblock allocation fails in setup_64.c
>> - Patch 1: Added alloc_stack() function in setup_32.c to also
>> panic in case of allocation failure.
>
> Hi Christophe,
>
> I can't get this series to boot on qemu mac99. I'm getting eg:
Problem new with version 13 or it is the first time you test ?
>
> [ 0.981514] NFS: Registering the id_resolver key type
> [ 0.981752] Key type id_resolver registered
> [ 0.981868] Key type id_legacy registered
> [ 0.995711] Unrecoverable exception 0 at 0 (msr=0)
> [ 0.996091] Oops: Unrecoverable exception, sig: 6 [#1]
> [ 0.996314] BE PAGE_SIZE=4K MMU=Hash PowerMac
> [ 0.996617] Modules linked in:
> [ 0.996869] CPU: 0 PID: 416 Comm: modprobe Not tainted
> 5.0.0-rc2-gcc-7.3.0-00043-g53f2de798792 #342
Comm:modprobe ==> Something wrong with modules ? I never tested with
CONFIG_MODULES.
Christophe
> [ 0.997138] NIP: 00000000 LR: 00000000 CTR: 00000000
> [ 0.997309] REGS: ef237f50 TRAP: 0000 Not tainted
> (5.0.0-rc2-gcc-7.3.0-00043-g53f2de798792)
> [ 0.997508] MSR: 00000000 <> CR: 00000000 XER: 00000000
> [ 0.997712]
> [ 0.997712] GPR00: 00000000 ef238000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 0.997712] GPR08: 00000000 00000000 00000000 00000000 00000000
> 00000000 c006477c ef13d8c0
> [ 0.997712] GPR16: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 0.997712] GPR24: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 0.998671] NIP [00000000] (null)
> [ 0.998774] LR [00000000] (null)
> [ 0.998895] Call Trace:
> [ 0.999030] Instruction dump:
> [ 0.999320] XXXXXXXX XXXXXXXX XXXXXXXX XXXXXXXX XXXXXXXX XXXXXXXX
> XXXXXXXX XXXXXXXX
> [ 0.999546] XXXXXXXX XXXXXXXX XXXXXXXX XXXXXXXX 60000000 XXXXXXXX
> XXXXXXXX XXXXXXXX
> [ 1.000023] ---[ end trace 925ea3419844fe68 ]---
>
> I haven't had time to dig any further.
>
> cheers
next prev parent reply other threads:[~2019-01-19 17:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 9:55 [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 01/10] powerpc/irq: use memblock functions returning virtual address Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 02/10] book3s/64: avoid circular header inclusion in mmu-hash.h Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 03/10] powerpc: Only use task_struct 'cpu' field on SMP Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 04/10] powerpc: Prepare for moving thread_info into task_struct Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 05/10] powerpc: Activate CONFIG_THREAD_INFO_IN_TASK Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 06/10] powerpc: regain entire stack space Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 07/10] powerpc: 'current_set' is now a table of task_struct pointers Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 08/10] powerpc/32: Remove CURRENT_THREAD_INFO and rename TI_CPU Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 09/10] powerpc/64: Remove CURRENT_THREAD_INFO Christophe Leroy
2019-01-12 9:55 ` [PATCH v13 10/10] powerpc: clean stack pointers naming Christophe Leroy
2019-01-19 10:23 ` [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK Michael Ellerman
2019-01-19 17:21 ` LEROY Christophe [this message]
2019-01-23 23:10 ` Michael Ellerman
2019-01-22 19:42 ` Christophe Leroy
2019-01-24 0:59 ` Michael Ellerman
2019-01-24 15:08 ` Christophe Leroy
2019-01-23 10:04 ` Christophe Leroy
2019-01-24 1:06 ` Michael Ellerman
2019-01-24 9:43 ` Christophe Leroy
2019-01-24 15:01 ` Christophe Leroy
2019-01-24 15:58 ` Christophe Leroy
2019-01-25 7:00 ` Gabriel Paubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119182113.Horde.DK6jqX3cEzsvR0fKFZrY2g4@messagerie.si.c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).