From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com,
kan.liang@intel.com
Subject: Re: [PATCH] perf tools: handle TOPOLOGY headers with no CPU
Date: Sun, 20 Jan 2019 19:19:25 +0100 [thread overview]
Message-ID: <20190120181925.GC8591@krava> (raw)
In-Reply-To: <1547885559-1657-1-git-send-email-eranian@google.com>
On Sat, Jan 19, 2019 at 12:12:39AM -0800, Stephane Eranian wrote:
> This patch fixes an issue in cpumap.c when used with the
> TOPOLOGY header. In some configurations, some NUMA nodes may
> have no CPU (empty cpulist). Yet a cpumap map must be created
> otherwise perf abort with an error. This patch handles this
> case by creating a dummy map.
>
> Before:
> $ perf record -o - -e cycles noploop 2 | perf script -i -
> 0x6e8 [0x6c]: failed to process type: 80
>
> After:
> $ perf record -o - -e cycles noploop 2 | perf script -i -
> noploop for 2 seconds
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> tools/perf/util/cpumap.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c
> index 1ccbd3342069..383674f448fc 100644
> --- a/tools/perf/util/cpumap.c
> +++ b/tools/perf/util/cpumap.c
> @@ -134,7 +134,12 @@ struct cpu_map *cpu_map__new(const char *cpu_list)
> if (!cpu_list)
> return cpu_map__read_all_cpu_map();
>
> - if (!isdigit(*cpu_list))
> + /*
> + * must handle the case of empty cpumap to cover
> + * TOPOLOGY header for NUMA nodes with no CPU
> + * ( e.g., because of CPU hotplug)
> + */
> + if (!isdigit(*cpu_list) && *cpu_list != '\0')
> goto out;
>
> while (isdigit(*cpu_list)) {
> @@ -181,8 +186,10 @@ struct cpu_map *cpu_map__new(const char *cpu_list)
>
> if (nr_cpus > 0)
> cpus = cpu_map__trim_new(nr_cpus, tmp_cpus);
> - else
> + else if (*cpu_list != '\0')
> cpus = cpu_map__default_new();
> + else
> + cpus = cpu_map__dummy_new();
> invalid:
> free(tmp_cpus);
> out:
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-01-20 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 8:12 [PATCH] perf tools: handle TOPOLOGY headers with no CPU Stephane Eranian
2019-01-20 18:19 ` Jiri Olsa [this message]
2019-01-22 11:36 ` [tip:perf/urgent] perf tools: Handle " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190120181925.GC8591@krava \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).