From: Johan Hovold <johan@kernel.org>
To: Paul Walmsley <paul@pwsan.com>
Cc: Johan Hovold <johan@kernel.org>,
Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Andreas Schwab <schwab@suse.de>,
linux-kernel@vger.kernel.org, Atish Patra <atish.patra@wdc.com>,
Anup Patel <anup@brainfault.org>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 4/5] riscv: treat cpu devicetree nodes without status as enabled
Date: Mon, 21 Jan 2019 09:59:34 +0100 [thread overview]
Message-ID: <20190121085934.GH3691@localhost> (raw)
In-Reply-To: <alpine.DEB.2.21.999.1901190140510.8813@utopia.booyaka.com>
On Sat, Jan 19, 2019 at 01:43:58AM +0000, Paul Walmsley wrote:
> On Fri, 18 Jan 2019, Johan Hovold wrote:
>
> > Follow the Linux convention and treat devicetree nodes without a status
> > property as enabled rather than disabled, while also allowing "ok" as a
> > shorthand for "okay".
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
>
> ... although I probably would have phrased the commit message slightly
> differently - something like "Use of_device_is_available() in
> riscv_of_processor_hartid(), in place of an open-coded test." That frames
> the change as one that removes custom code in place of an existing
> standard function for the same purpose.
You're right, and that was my motivation too. In the end I decided to
highlight the side effect in case someone was perhaps unknowingly
relying on the current behaviour.
Thanks for the review!
Johan
next prev parent reply other threads:[~2019-01-21 8:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 14:03 [PATCH 0/5] riscv: minor fixes and cleanups Johan Hovold
2019-01-18 14:03 ` [PATCH 1/5] riscv: add missing newlines to printk messages Johan Hovold
2019-02-12 7:11 ` Christoph Hellwig
2019-01-18 14:03 ` [PATCH 2/5] riscv: use pr_info and friends Johan Hovold
2019-01-19 1:39 ` Paul Walmsley
2019-02-12 7:11 ` Christoph Hellwig
2019-01-18 14:03 ` [PATCH 3/5] riscv: fix riscv_of_processor_hartid() comment Johan Hovold
2019-01-19 1:40 ` Paul Walmsley
2019-02-12 7:12 ` Christoph Hellwig
2019-01-18 14:03 ` [PATCH 4/5] riscv: treat cpu devicetree nodes without status as enabled Johan Hovold
2019-01-19 1:43 ` Paul Walmsley
2019-01-21 8:59 ` Johan Hovold [this message]
2019-02-12 7:12 ` Christoph Hellwig
2019-01-18 14:03 ` [PATCH 5/5] riscv: use for_each_of_cpu_node iterator Johan Hovold
2019-02-12 7:13 ` Christoph Hellwig
2019-02-12 8:26 ` Johan Hovold
2019-02-12 8:47 ` Atish Patra
2019-02-12 8:53 ` Johan Hovold
2019-02-12 9:20 ` Atish Patra
2019-02-11 9:34 ` [PATCH 0/5] riscv: minor fixes and cleanups Johan Hovold
2019-02-11 19:59 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121085934.GH3691@localhost \
--to=johan@kernel.org \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul@pwsan.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).