From: Greg KH <gregkh@linuxfoundation.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: jens.wiklander@linaro.org, herbert@gondor.apana.org.au,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
mpm@selenic.com, robh+dt@kernel.org, mark.rutland@arm.com,
arnd@arndb.de, daniel.thompson@linaro.org,
ard.biesheuvel@linaro.org, bhsharma@redhat.com,
tee-dev@lists.linaro.org
Subject: Re: [PATCH v4 4/4] hwrng: add OP-TEE based rng driver
Date: Mon, 21 Jan 2019 11:30:26 +0100 [thread overview]
Message-ID: <20190121103026.GB15590@kroah.com> (raw)
In-Reply-To: <1548062959-31860-5-git-send-email-sumit.garg@linaro.org>
On Mon, Jan 21, 2019 at 02:59:19PM +0530, Sumit Garg wrote:
> --- /dev/null
> +++ b/drivers/char/hw_random/optee-rng.c
> @@ -0,0 +1,272 @@
> +// SPDX-License-Identifier: GPL-2.0
Nice, but:
<snip>
> +MODULE_LICENSE("GPL");
This string means "GPL2+", you need "GPLv2" here instead.
Yeah, it's a pain, and everyone gets it wrong, we need to add a
checkpatch.pl rule for this to keep it from being added in new code.
thanks,
greg k-h
next prev parent reply other threads:[~2019-01-21 10:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 9:29 [PATCH v4 0/4] Introduce TEE bus driver framework Sumit Garg
2019-01-21 9:29 ` [PATCH v4 1/4] tee: add bus driver framework for TEE based devices Sumit Garg
2019-01-21 15:28 ` Bhupesh Sharma
2019-01-22 13:33 ` Sumit Garg
2019-01-21 9:29 ` [PATCH v4 2/4] tee: add supp_nowait flag in tee_context struct Sumit Garg
2019-01-21 9:29 ` [PATCH v4 3/4] tee: optee: add TEE bus device enumeration support Sumit Garg
2019-01-21 9:29 ` [PATCH v4 4/4] hwrng: add OP-TEE based rng driver Sumit Garg
2019-01-21 10:03 ` Ard Biesheuvel
2019-01-21 12:59 ` Sumit Garg
2019-01-21 13:02 ` Ard Biesheuvel
2019-01-21 13:13 ` Sumit Garg
2019-01-21 10:30 ` Greg KH [this message]
2019-01-21 10:43 ` Ard Biesheuvel
2019-01-21 10:46 ` Greg KH
2019-01-21 13:01 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121103026.GB15590@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bhsharma@redhat.com \
--cc=daniel.thompson@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mpm@selenic.com \
--cc=robh+dt@kernel.org \
--cc=sumit.garg@linaro.org \
--cc=tee-dev@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).