From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E428C2F3A0 for ; Mon, 21 Jan 2019 13:59:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4556E2087F for ; Mon, 21 Jan 2019 13:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548079146; bh=UiA7FTSTYOBbclCEqL/whm0QzziHz8lW0tXMI+x4SBg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nE3xZ5FNtr6fTdyftVWgeZ8k6BBUt7xgjtsG2cpR55GDV0+MN6BACJTMlzLcQe5ti Txi/rSQh2AjcJed6NsMHoHAVQcQBwihDpYVUQQNMZPyuyUBcA9x3PIOEQI0nnt8BTn ATMoqdl4Ye7HMPTlhC2h8HbxVnY2a+mXyv9ZON40= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730694AbfAUN7F (ORCPT ); Mon, 21 Jan 2019 08:59:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:44876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732121AbfAUN7B (ORCPT ); Mon, 21 Jan 2019 08:59:01 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD14020879; Mon, 21 Jan 2019 13:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548079141; bh=UiA7FTSTYOBbclCEqL/whm0QzziHz8lW0tXMI+x4SBg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z2PTA1v6oVDuuwyvETmMJj7kfRTmwLpxvdgyXyYrNgOnLqp+E91KymK8R3dcktfSC /MhEydv2A83nCMnTxoYbzXzEJHfR7PjWzZNzDnczp+OUqWqomx3G+VyNpavKc6W8++ 6xa5D5hNPawZpjNhmORmB2m2ZFcIj0VTGNGh0imc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leon Romanovsky , Jason Gunthorpe , Willem de Bruijn , "David S. Miller" Subject: [PATCH 4.19 22/99] packet: Do not leak dev refcounts on error exit Date: Mon, 21 Jan 2019 14:48:14 +0100 Message-Id: <20190121134914.751181668@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190121134913.924726465@linuxfoundation.org> References: <20190121134913.924726465@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jason Gunthorpe [ Upstream commit d972f3dce8d161e2142da0ab1ef25df00e2f21a9 ] 'dev' is non NULL when the addr_len check triggers so it must goto a label that does the dev_put otherwise dev will have a leaked refcount. This bug causes the ib_ipoib module to become unloadable when using systemd-network as it triggers this check on InfiniBand links. Fixes: 99137b7888f4 ("packet: validate address length") Reported-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Acked-by: Willem de Bruijn Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/packet/af_packet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -2628,7 +2628,7 @@ static int tpacket_snd(struct packet_soc addr = saddr->sll_halen ? saddr->sll_addr : NULL; dev = dev_get_by_index(sock_net(&po->sk), saddr->sll_ifindex); if (addr && dev && saddr->sll_halen < dev->addr_len) - goto out; + goto out_put; } err = -ENXIO; @@ -2828,7 +2828,7 @@ static int packet_snd(struct socket *soc addr = saddr->sll_halen ? saddr->sll_addr : NULL; dev = dev_get_by_index(sock_net(sk), saddr->sll_ifindex); if (addr && dev && saddr->sll_halen < dev->addr_len) - goto out; + goto out_unlock; } err = -ENXIO;