From: Moritz Fischer <mdf@kernel.org>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
moritz@ettus.com
Subject: Re: [PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs
Date: Mon, 21 Jan 2019 10:40:17 -0800 [thread overview]
Message-ID: <20190121184017.GA5761@archbook> (raw)
In-Reply-To: <CAFqH_53Mdh6chEDTkNH_ZGC6scHhXXgp7zdDaSS2Xfd--dfrNQ@mail.gmail.com>
Hi Enrico,
On Mon, Jan 21, 2019 at 06:32:48PM +0100, Enric Balletbo Serra wrote:
> Hi Moritz,
>
> Missatge de Moritz Fischer <mdf@kernel.org> del dia dj., 10 de gen.
> 2019 a les 5:40:
> >
> > Add cros_ec_readmem() helpers for I2C/SPI based ECs.
> > Unlike the LPC based ECs the I2C/SPI based ones cannot just directly
> > read the mapped region, but have to resort to EC_CMD_READ_MEMMAP.
> >
> > This is useful for things like accessing fan speeds or temperatures.
> >
> > Signed-off-by: Moritz Fischer <mdf@kernel.org>
> > ---
> >
> > Hi all,
> >
> > This can be used for a hwmon or thermal driver such as [1], but also
> > alone can be used with 'ectool' via the ioctl() interface.
> >
>
> ooi, did you try this with a Chromebook? Or only with your device?
Nope, mine has a dead battery (and no fans ... :-/)
>
> I was a bit worried on the side effects to expose this command to
> userspace, so I did a quick test, and to be honest I didn't like the
> result. Issuing the ioctl resulted on a reboot on the Chromebook I
> tested, which is not good. I didn't investigate more but I can say
> that this change, at least, will need some rework. I'll try to
> investigate a bit more on what is happening.
That sounds bad :-/
What chromebook did you run this on (so I can look at the EC code it is
running and figure out what's the difference). Maybe it has a different
configuration. It wasn't an x86 chromebook, right?
What was the ioctl you ran?
Thanks for testing,
Moritz
next prev parent reply other threads:[~2019-01-21 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 4:36 [PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs Moritz Fischer
2019-01-21 17:32 ` Enric Balletbo Serra
2019-01-21 18:40 ` Moritz Fischer [this message]
2019-01-21 22:19 ` Enric Balletbo Serra
2019-01-22 21:09 ` Moritz Fischer
2019-01-23 11:33 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121184017.GA5761@archbook \
--to=mdf@kernel.org \
--cc=bleung@chromium.org \
--cc=eballetbo@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moritz@ettus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).