linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Tony Lindgren <tony@atomide.com>
Cc: Arthur Demchenkov <spinal.by@gmail.com>,
	bcousson@baylibre.com, robh+dt@kernel.org, mark.rutland@arm.com,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity
Date: Mon, 21 Jan 2019 21:45:53 +0200	[thread overview]
Message-ID: <20190121194552.GA2792@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <20190121171101.GD5544@atomide.com>

Hi,

On Mon, Jan 21, 2019 at 09:11:01AM -0800, Tony Lindgren wrote:
> * Arthur Demchenkov <spinal.by@gmail.com> [190121 03:22]:
> > Wrong polarity of card detect GPIO pin leads to the system not
> > booting from external mmc, if the back cover of N900 is closed.
> > When the cover is open the system boots fine.
> > 
> > This wasn't noticed before, because of a bug, which was fixed
> > by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO
> > CD and WP).
> 
> Aaro, does this work for your test case too?

Yeah..

> > Kernels up to 4.19 ignored the card detect GPIO from DT.
> 
> Hmm so should this have a Fixes tag or not?

I think it should as v4.20 is broken.

A.

> Regards,
> 
> Tony
> 
> >  arch/arm/boot/dts/omap3-n900.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> > index 182a53991c90..826920e6b878 100644
> > --- a/arch/arm/boot/dts/omap3-n900.dts
> > +++ b/arch/arm/boot/dts/omap3-n900.dts
> > @@ -814,7 +814,7 @@
> >  	/* For debugging, it is often good idea to remove this GPIO.
> >  	   It means you can remove back cover (to reboot by removing
> >  	   battery) and still use the MMC card. */
> > -	cd-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>; /* 160 */
> > +	cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */
> >  };
> >  
> >  /* most boards use vaux3, only some old versions use vmmc2 instead */
> > -- 
> > 2.11.0
> > 

  reply	other threads:[~2019-01-21 19:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21  3:21 [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity Arthur Demchenkov
2019-01-21 17:11 ` Tony Lindgren
2019-01-21 19:45   ` Aaro Koskinen [this message]
2019-01-21 17:52 ` Fabio Estevam
2019-01-21 20:00   ` Tony Lindgren
2019-01-22  4:59     ` Arthur D.
2019-01-22 22:56       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190121194552.GA2792@darkstar.musicnaut.iki.fi \
    --to=aaro.koskinen@iki.fi \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=spinal.by@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).