From: Quentin Perret <quentin.perret@arm.com>
To: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-api@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Paul Turner <pjt@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Juri Lelli <juri.lelli@redhat.com>, Todd Kjos <tkjos@google.com>,
Joel Fernandes <joelaf@google.com>,
Steve Muckle <smuckle@google.com>,
Suren Baghdasaryan <surenb@google.com>
Subject: Re: [PATCH v6 11/16] sched/fair: Add uclamp support to energy_compute()
Date: Tue, 22 Jan 2019 12:13:22 +0000 [thread overview]
Message-ID: <20190122121321.r6mv23ao57uut3t7@queper01-lin> (raw)
In-Reply-To: <20190115101513.2822-12-patrick.bellasi@arm.com>
On Tuesday 15 Jan 2019 at 10:15:08 (+0000), Patrick Bellasi wrote:
> The Energy Aware Scheduler (AES) estimates the energy impact of waking
s/AES/EAS :-)
[...]
> + for_each_cpu_and(cpu, pd_mask, cpu_online_mask) {
> + cfs_util = cpu_util_next(cpu, p, dst_cpu);
> +
> + /*
> + * Busy time computation: utilization clamping is not
> + * required since the ratio (sum_util / cpu_capacity)
> + * is already enough to scale the EM reported power
> + * consumption at the (eventually clamped) cpu_capacity.
> + */
Right.
> + sum_util += schedutil_cpu_util(cpu, cfs_util, cpu_cap,
> + ENERGY_UTIL, NULL);
> +
> + /*
> + * Performance domain frequency: utilization clamping
> + * must be considered since it affects the selection
> + * of the performance domain frequency.
> + */
So that actually affects the way we deal with RT I think. I assume the
idea is to say if you don't want to reflect the RT-go-to-max-freq thing
in EAS (which is what we do now) you should set the min cap for RT to 0.
Is that correct ?
I'm fine with this conceptually but maybe the specific case of RT should
be mentioned somewhere in the commit message or so ? I think it's
important to say that clearly since this patch changes the default
behaviour.
> + cpu_util = schedutil_cpu_util(cpu, cfs_util, cpu_cap,
> + FREQUENCY_UTIL,
> + cpu == dst_cpu ? p : NULL);
> + max_util = max(max_util, cpu_util);
> }
>
> energy += em_pd_energy(pd->em_pd, max_util, sum_util);
Thanks,
Quentin
next prev parent reply other threads:[~2019-01-22 12:13 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 10:14 [PATCH v6 00/16] Add utilization clamping support Patrick Bellasi
2019-01-15 10:14 ` [PATCH v6 01/16] sched/core: Allow sched_setattr() to use the current policy Patrick Bellasi
2019-01-25 13:56 ` Alessio Balsini
2019-01-15 10:14 ` [PATCH v6 02/16] sched/core: uclamp: Extend sched_setattr() to support utilization clamping Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 03/16] sched/core: uclamp: Map TASK's clamp values into CPU's clamp buckets Patrick Bellasi
2019-01-21 10:15 ` Peter Zijlstra
2019-01-21 12:27 ` Patrick Bellasi
2019-01-21 12:51 ` Peter Zijlstra
2019-01-21 15:05 ` Peter Zijlstra
2019-01-21 15:34 ` Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 04/16] sched/core: uclamp: Add CPU's clamp buckets refcounting Patrick Bellasi
2019-01-21 14:59 ` Peter Zijlstra
2019-01-21 15:23 ` Patrick Bellasi
2019-01-21 16:12 ` Peter Zijlstra
2019-01-21 16:33 ` Patrick Bellasi
2019-01-22 9:45 ` Peter Zijlstra
2019-01-22 10:31 ` Patrick Bellasi
2019-01-21 15:17 ` Peter Zijlstra
2019-01-21 15:54 ` Patrick Bellasi
2019-01-22 10:03 ` Peter Zijlstra
2019-01-22 10:53 ` Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 05/16] sched/core: uclamp: Update CPU's refcount on clamp changes Patrick Bellasi
2019-01-21 15:33 ` Peter Zijlstra
2019-01-21 15:44 ` Patrick Bellasi
2019-01-22 9:37 ` Peter Zijlstra
2019-01-22 10:43 ` Patrick Bellasi
2019-01-22 13:28 ` Peter Zijlstra
2019-01-22 14:01 ` Patrick Bellasi
2019-01-22 14:57 ` Peter Zijlstra
2019-01-22 15:33 ` Patrick Bellasi
2019-01-23 9:16 ` Peter Zijlstra
2019-01-23 14:14 ` Patrick Bellasi
2019-01-23 18:59 ` Peter Zijlstra
2019-01-24 11:21 ` Patrick Bellasi
2019-01-24 12:38 ` Peter Zijlstra
2019-01-15 10:15 ` [PATCH v6 06/16] sched/core: uclamp: Enforce last task UCLAMP_MAX Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 07/16] sched/core: uclamp: Add system default clamps Patrick Bellasi
2019-01-22 13:56 ` Peter Zijlstra
2019-01-22 14:43 ` Patrick Bellasi
2019-01-22 15:13 ` Peter Zijlstra
2019-01-22 15:41 ` Patrick Bellasi
2019-01-23 9:22 ` Peter Zijlstra
2019-01-23 14:19 ` Patrick Bellasi
2019-01-23 19:10 ` Peter Zijlstra
2019-01-15 10:15 ` [PATCH v6 08/16] sched/cpufreq: uclamp: Add utilization clamping for FAIR tasks Patrick Bellasi
2019-01-22 10:37 ` Rafael J. Wysocki
2019-01-22 11:02 ` Patrick Bellasi
2019-01-22 11:04 ` Rafael J. Wysocki
2019-01-22 11:27 ` Patrick Bellasi
2019-01-22 15:21 ` Peter Zijlstra
2019-01-22 15:45 ` Patrick Bellasi
2019-01-22 17:13 ` Peter Zijlstra
2019-01-22 18:18 ` Patrick Bellasi
2019-01-23 9:52 ` Peter Zijlstra
2019-01-23 14:24 ` Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 09/16] sched/cpufreq: uclamp: Add utilization clamping for RT tasks Patrick Bellasi
2019-01-22 12:30 ` Quentin Perret
2019-01-22 12:37 ` Patrick Bellasi
2019-01-23 10:28 ` Peter Zijlstra
2019-01-23 14:33 ` Patrick Bellasi
2019-01-23 10:49 ` Peter Zijlstra
2019-01-23 14:40 ` Patrick Bellasi
2019-01-23 20:11 ` Peter Zijlstra
2019-01-24 12:30 ` Patrick Bellasi
2019-01-24 12:38 ` Patrick Bellasi
2019-01-24 15:12 ` Peter Zijlstra
2019-01-24 16:00 ` Patrick Bellasi
2019-01-24 15:31 ` Peter Zijlstra
2019-01-24 16:14 ` Patrick Bellasi
2019-01-24 15:33 ` Peter Zijlstra
2019-01-24 15:15 ` Peter Zijlstra
2019-01-24 16:05 ` Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 10/16] sched/core: Add uclamp_util_with() Patrick Bellasi
2019-01-23 13:33 ` Peter Zijlstra
2019-01-23 14:51 ` Patrick Bellasi
2019-01-23 19:22 ` Peter Zijlstra
2019-01-15 10:15 ` [PATCH v6 11/16] sched/fair: Add uclamp support to energy_compute() Patrick Bellasi
2019-01-22 12:13 ` Quentin Perret [this message]
2019-01-22 12:45 ` Patrick Bellasi
2019-01-22 13:29 ` Quentin Perret
2019-01-22 14:26 ` Patrick Bellasi
2019-01-22 14:39 ` Quentin Perret
2019-01-22 15:01 ` Patrick Bellasi
2019-01-22 15:14 ` Quentin Perret
2019-01-15 10:15 ` [PATCH v6 12/16] sched/core: uclamp: Extend CPU's cgroup controller Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 13/16] sched/core: uclamp: Propagate parent clamps Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 14/16] sched/core: uclamp: Map TG's clamp values into CPU's clamp buckets Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 15/16] sched/core: uclamp: Use TG's clamps to restrict TASK's clamps Patrick Bellasi
2019-01-15 10:15 ` [PATCH v6 16/16] sched/core: uclamp: Update CPU's refcount on TG's clamp changes Patrick Bellasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122121321.r6mv23ao57uut3t7@queper01-lin \
--to=quentin.perret@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=smuckle@google.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=tkjos@google.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).