From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C29C282C5 for ; Tue, 22 Jan 2019 15:13:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A628A20855 for ; Tue, 22 Jan 2019 15:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729202AbfAVPNr (ORCPT ); Tue, 22 Jan 2019 10:13:47 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:60100 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729015AbfAVPNr (ORCPT ); Tue, 22 Jan 2019 10:13:47 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gportay) with ESMTPSA id 70BA126040B Date: Tue, 22 Jan 2019 10:13:48 -0500 From: =?utf-8?B?R2HDq2w=?= PORTAY To: Philipp Zabel Cc: Steve Longerbeam , linux-media@vger.kernel.org, Peter Seiderer , stable@vger.kernel.org, Mauro Carvalho Chehab , Greg Kroah-Hartman , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel Message-ID: <20190122151348.vme7256fhxpkvxvq@archlinux.localdomain> References: <20190119010457.2623-1-slongerbeam@gmail.com> <20190119010457.2623-2-slongerbeam@gmail.com> <1548071350.3287.3.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1548071350.3287.3.camel@pengutronix.de> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Philipp, On Mon, Jan 21, 2019 at 12:49:10PM +0100, Philipp Zabel wrote: > Hi, > > On Fri, 2019-01-18 at 17:04 -0800, Steve Longerbeam wrote: > > Disable the SMFC before disabling the IDMA channel, instead of after, > > in csi_idmac_unsetup(). > > > > This fixes a complete system hard lockup on the SabreAuto when streaming > > from the ADV7180, by repeatedly sending a stream off immediately followed > > by stream on: > > > > while true; do v4l2-ctl -d4 --stream-mmap --stream-count=3; done > > > > Eventually this either causes the system lockup or EOF timeouts at all > > subsequent stream on, until a system reset. > > > > The lockup occurs when disabling the IDMA channel at stream off. Stopping > > the video data stream entering the IDMA channel before disabling the > > channel itself appears to be a reliable fix for the hard lockup. That can > > be done either by disabling the SMFC or the CSI before disabling the > > channel. Disabling the SMFC before the channel is the easiest solution, > > so do that. > > > > Fixes: 4a34ec8e470cb ("[media] media: imx: Add CSI subdev driver") > > > > Suggested-by: Peter Seiderer > > Reported-by: Gaël PORTAY > > Signed-off-by: Steve Longerbeam > > Gaël, could we get a Tested-by: for this as well? > I have tested the patchset v4 (not that one), and it has passed my test. Regards, Gael