From: Johan Hovold <johan@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Andreas Kemnade <andreas@kemnade.info>, Johan Hovold <johan@kernel.org>
Subject: [PATCH 3/3] gnss: sirf: drop redundant double negation
Date: Tue, 22 Jan 2019 18:22:55 +0100 [thread overview]
Message-ID: <20190122172255.17944-4-johan@kernel.org> (raw)
In-Reply-To: <20190122172255.17944-1-johan@kernel.org>
The active flag is of type bool so drop the redundant double negation
when storing the gpio state.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/gnss/sirf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c
index f9a9d00dec98..59cde7e923b8 100644
--- a/drivers/gnss/sirf.c
+++ b/drivers/gnss/sirf.c
@@ -125,7 +125,7 @@ static irqreturn_t sirf_wakeup_handler(int irq, void *dev_id)
if (ret < 0)
goto out;
- data->active = !!ret;
+ data->active = ret;
wake_up_interruptible(&data->power_wait);
out:
return IRQ_HANDLED;
--
2.20.1
next prev parent reply other threads:[~2019-01-22 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 17:22 [PATCH 0/3] gnss: sirf: fixes and cleanup Johan Hovold
2019-01-22 17:22 ` [PATCH 1/3] gnss: sirf: fix premature wakeup interrupt enable Johan Hovold
2019-01-22 17:22 ` [PATCH 2/3] gnss: sirf: force hibernate mode on probe Johan Hovold
2019-01-22 17:22 ` Johan Hovold [this message]
2019-01-22 22:10 ` [PATCH 0/3] gnss: sirf: fixes and cleanup Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122172255.17944-4-johan@kernel.org \
--to=johan@kernel.org \
--cc=andreas@kemnade.info \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).