From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/armada: replace the simple-framebuffer
Date: Tue, 22 Jan 2019 19:03:21 +0000 [thread overview]
Message-ID: <20190122190320.3lfi7ff7oxmnxymj@e5254000004ec.dyn.armlinux.org.uk> (raw)
In-Reply-To: <20190121060157.549544-1-lkundrak@v3.sk>
On Mon, Jan 21, 2019 at 07:01:57AM +0100, Lubomir Rintel wrote:
> If there's a simple-framebuffer carried over from boot firmware, it's going
> to stop working once we setup the LCDC for use via DRM. Kick it off from
> the hardware.
Applied, thanks.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/gpu/drm/armada/armada_drv.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
> index fa31589b4fc0..9fcf88c91758 100644
> --- a/drivers/gpu/drm/armada/armada_drv.c
> +++ b/drivers/gpu/drm/armada/armada_drv.c
> @@ -100,6 +100,17 @@ static int armada_drm_bind(struct device *dev)
> return ret;
> }
>
> + /* Remove early framebuffers */
> + ret = drm_fb_helper_remove_conflicting_framebuffers(NULL,
> + "armada-drm-fb",
> + false);
> + if (ret) {
> + dev_err(dev, "[" DRM_NAME ":%s] can't kick out simple-fb: %d\n",
> + __func__, ret);
> + kfree(priv);
> + return ret;
> + }
> +
> priv->drm.dev_private = priv;
>
> dev_set_drvdata(dev, &priv->drm);
> --
> 2.20.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
prev parent reply other threads:[~2019-01-22 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 6:01 [PATCH] drm/armada: replace the simple-framebuffer Lubomir Rintel
2019-01-22 19:03 ` Russell King - ARM Linux admin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122190320.3lfi7ff7oxmnxymj@e5254000004ec.dyn.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).