From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
Cc: Peter Rosin <peda@axentia.se>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
Mark Rutland <mark.rutland@arm.com>,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 1/5] dt-bindings: display: bridge: fork out ti,ds90c185 from lvds-transmitter
Date: Tue, 22 Jan 2019 22:53:45 +0200 [thread overview]
Message-ID: <20190122205345.GF3264@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190111144904.GA5052@bogus>
Hello,
On Fri, Jan 11, 2019 at 08:49:04AM -0600, Rob Herring wrote:
> On Sat, Dec 29, 2018 at 07:07:19AM +0000, Peter Rosin wrote:
> > DS90C185 has a shutdown pin which does not fit in the lvds-transmitter
> > binding, which is meant to be generic.
> >
> > The sister chip DS90C187 is similar to DS90C185, describe it here as well.
> >
> > Signed-off-by: Peter Rosin <peda@axentia.se>
> > ---
> > .../bindings/display/bridge/lvds-transmitter.txt | 8 +---
> > .../bindings/display/bridge/ti,ds90c185.txt | 55 ++++++++++++++++++++++
> > 2 files changed, 56 insertions(+), 7 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> > index 50220190c203..fd39ad34c383 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> > @@ -22,13 +22,7 @@ among others.
> >
> > Required properties:
> >
> > -- compatible: Must be one or more of the following
> > - - "ti,ds90c185" for the TI DS90C185 FPD-Link Serializer
> > - - "lvds-encoder" for a generic LVDS encoder device
> > -
> > - When compatible with the generic version, nodes must list the
> > - device-specific version corresponding to the device first
> > - followed by the generic version.
>
> I think you should keep something here. I'd reword it to say any encoder
> with additional properties must have a device specific compatible in
> addition.
I was going to mention this too. Maybe
- compatible: Shall contain a device-specific compatible string follow
by "lvds-encoder".
That's stronger than Rob's suggestion, as I don't think we should allow
omitting the device-specific compatible string in any case to make sure
we can preserve backward compatibility in the future.
> > +- compatible: Must be "lvds-encoder"
> >
> > Required nodes:
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt
> > new file mode 100644
> > index 000000000000..e575f996959a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt
> > @@ -0,0 +1,55 @@
> > +Texas Instruments FPD-Link (LVDS) Serializer
> > +--------------------------------------------
> > +
> > +The DS90C185 and DS90C187 are low-power serializers for portable
> > +battery-powered applications that reduces the size of the RGB
> > +interface between the host GPU and the display.
> > +
> > +Required properties:
> > +
> > +- compatible: Should be
> > + "ti,ds90c185", "lvds-encoder" for the TI DS90C185 FPD-Link Serializer
> > + "ti,ds90c187", "lvds-encoder" for the TI DS90C187 FPD-Link Serializer
s/ for/ for/
With these fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > +
> > +Optional properties:
> > +
> > +- powerdown-gpios: Power down control GPIO (the PDB pin, active-low)
> > +
> > +Required nodes:
> > +
> > +The devices have two video ports. Their connections are modeled using the OF
> > +graph bindings specified in Documentation/devicetree/bindings/graph.txt.
> > +
> > +- Video port 0 for parallel input
> > +- Video port 1 for LVDS output
> > +
> > +
> > +Example
> > +-------
> > +
> > +lvds-encoder {
> > + compatible = "ti,ds90c185", "lvds-encoder";
> > +
> > + powerdown-gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> > +
> > + lvds_enc_in: endpoint {
> > + remote-endpoint = <&lcdc_out_rgb>;
> > + };
> > + };
> > +
> > + port@1 {
> > + reg = <1>;
> > +
> > + lvds_enc_out: endpoint {
> > + remote-endpoint = <&lvds_panel_in>;
> > + };
> > + };
> > + };
> > +};
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-01-22 20:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 7:07 [PATCH v3 0/5] drm/bridge: various small lvds-encoder things Peter Rosin
2018-12-29 7:07 ` [PATCH v3 1/5] dt-bindings: display: bridge: fork out ti,ds90c185 from lvds-transmitter Peter Rosin
2019-01-11 14:49 ` Rob Herring
2019-01-22 20:53 ` Laurent Pinchart [this message]
2018-12-29 7:07 ` [PATCH v3 2/5] dt-bindings: display: bridge: lvds-transmitter: cleanup example Peter Rosin
2019-01-22 20:45 ` Laurent Pinchart
2018-12-29 7:07 ` [PATCH v3 3/5] dt-bindings: display: bridge: thc63lvdm83d: use standard powerdown-gpios Peter Rosin
2019-01-11 14:49 ` Rob Herring
2019-01-22 20:54 ` Laurent Pinchart
2018-12-29 7:07 ` [PATCH v3 4/5] drm/bridge: lvds-encoder: add dev helper variable in .probe() Peter Rosin
2019-01-22 20:55 ` Laurent Pinchart
2018-12-29 7:07 ` [PATCH v3 5/5] drm/bridge: lvds-encoder: add powerdown-gpios support Peter Rosin
2019-01-22 21:01 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122205345.GF3264@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).