linux-next: Fixes tag needs some work in the omap-fixes tree

linux-next: Fixes tag needs some work in the omap-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Hi Tony,

In commit

  5a1826e1b175 ("ARM: dts: am335x-shc.dts: fix wrong cd pin level")

Fixes tag

  Fixes: e63201f19438 ("mmc: omap_hsmmc: Delete platform data

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  0b30afcb8948 ("ARM: dts: n900: fix mmc1 card detect gpio polarity")

Fixes tag

  Fixes: e63201f19438 ("mmc: omap_hsmmc: Delete platform data GPIO

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags across more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the omap-fixes tree

[Tony Lindgren]

Hi,

* Stephen Rothwell <sfr@canb.auug.org.au> [190123 05:32]:
> Please do not split Fixes tags across more than one line.

OK fine with me.

Regards,

Tony

Re: linux-next: Fixes tag needs some work in the omap-fixes tree

[Tony Lindgren]

* H. Nikolaus Schaller <hns@goldelico.com> [220413 06:19]:
> Hi Stephen,
> 
> > Am 12.04.2022 um 23:02 schrieb Stephen Rothwell <sfr@canb.auug.org.au>:
> > 
> > Hi all,
> > 
> > In commit
> > 
> >  9be24a73de12 ("ARM: dts: Fix mmc order for omap3-gta04")
> > 
> > Fixes tag
> > 
> >  Fixes: commit a1ebdb374199 ("ARM: dts: Fix swapped mmc order for omap3")
> > 
> > has these problem(s):
> > 
> >  - leading word 'commit' unexpected
> 
> Ah, I see.
> Diff of patch is good but the commit message needs editing.
> 
> What is the procedure to fix this case?

Thanks for catching this, no need to do anything. I've fixed it up
and pushed out an updated fixes branch.

Regards,

TOny

Re: linux-next: Fixes tag needs some work in the omap-fixes tree

[H. Nikolaus Schaller]

Hi Stephen,

> Am 12.04.2022 um 23:02 schrieb Stephen Rothwell <sfr@canb.auug.org.au>:
> 
> Hi all,
> 
> In commit
> 
>  9be24a73de12 ("ARM: dts: Fix mmc order for omap3-gta04")
> 
> Fixes tag
> 
>  Fixes: commit a1ebdb374199 ("ARM: dts: Fix swapped mmc order for omap3")
> 
> has these problem(s):
> 
>  - leading word 'commit' unexpected

Ah, I see.
Diff of patch is good but the commit message needs editing.

What is the procedure to fix this case?

BR and thanks,
Nikolaus

linux-next: Fixes tag needs some work in the omap-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

Hi all,

In commit

  9be24a73de12 ("ARM: dts: Fix mmc order for omap3-gta04")

Fixes tag

  Fixes: commit a1ebdb374199 ("ARM: dts: Fix swapped mmc order for omap3")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the omap-fixes tree

[Tony Lindgren]

* Stephen Rothwell <sfr@canb.auug.org.au> [201110 21:16]:
> Hi all,
> 
> In commit
> 
>   e4b5575da267 ("ARM: OMAP2+: Manage MPU state properly for omap_enter_idle_coupled()")
> 
> Fixes tag
> 
>   Fixes: 8ca5ee624b4c ("ARM: OMAP2+: Restore MPU power domain if cpu_cluster_pm_enter() fails")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meeant
> 
> Fixes: 8f04aea048d5 ("ARM: OMAP2+: Restore MPU power domain if cpu_cluster_pm_enter() fails")

Thanks for catching it, will fix!

Tony

linux-next: Fixes tag needs some work in the omap-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

Hi all,

In commit

  e4b5575da267 ("ARM: OMAP2+: Manage MPU state properly for omap_enter_idle_coupled()")

Fixes tag

  Fixes: 8ca5ee624b4c ("ARM: OMAP2+: Restore MPU power domain if cpu_cluster_pm_enter() fails")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meeant

Fixes: 8f04aea048d5 ("ARM: OMAP2+: Restore MPU power domain if cpu_cluster_pm_enter() fails")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the omap-fixes tree

[Tony Lindgren]

* Stephen Rothwell <sfr@canb.auug.org.au> [191217 20:53]:
> Hi all,
> 
> In commit
> 
>   d094e1b4b232 ("ARM: dts: am571x-idk: Fix gpios property to have the correct  gpio number")
> 
> Fixes tag
> 
>   Fixes: d23f3839fe97d8dce03d ("ARM: dts: DRA7: Add pcie1 dt node for
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not break FIxes tags over more that one line.  Also, keep all
> the tags together at the end of the commit message.

Thanks will fix up.

Tony

linux-next: Fixes tag needs some work in the omap-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

Hi all,

In commit

  d094e1b4b232 ("ARM: dts: am571x-idk: Fix gpios property to have the correct  gpio number")

Fixes tag

  Fixes: d23f3839fe97d8dce03d ("ARM: dts: DRA7: Add pcie1 dt node for

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not break FIxes tags over more that one line.  Also, keep all
the tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the omap-fixes tree

[Tony Lindgren]

Hi,

* Stephen Rothwell <sfr@canb.auug.org.au> [190910 14:25]:
> Hi all,
> 
> In commit
> 
>   a932b77b4d19 ("ARM: dts: logicpd-som-lv: Fix i2c2 and i2c3 Pin mux")
> 
> Fixes tag
> 
>   Fixes: 5fe3c0fa0d54 ("ARM: dts: Add pinmuxing for i2c2 and i2c3
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line (and also just
> keep them with all the other tags).

Oops sorry I missed that again, will try to be more careful
the next time. I really should have some automated checks
in place for that..

Regards,

Tony

linux-next: Fixes tag needs some work in the omap-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

Hi all,

In commit

  a932b77b4d19 ("ARM: dts: logicpd-som-lv: Fix i2c2 and i2c3 Pin mux")

Fixes tag

  Fixes: 5fe3c0fa0d54 ("ARM: dts: Add pinmuxing for i2c2 and i2c3

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line (and also just
keep them with all the other tags).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]