From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC835C282C0 for ; Wed, 23 Jan 2019 21:15:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90B0C2184C for ; Wed, 23 Jan 2019 21:15:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="4UfcQFXp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726872AbfAWVPW (ORCPT ); Wed, 23 Jan 2019 16:15:22 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:55434 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726322AbfAWVPV (ORCPT ); Wed, 23 Jan 2019 16:15:21 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0NLCdvd078751; Wed, 23 Jan 2019 21:14:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=tHRsqY7hYsYW0qg1V0wqfXfnDWK5tNc/hvLDteqYG84=; b=4UfcQFXpfU6KMzwqNkZSSHYXfdavILuYSycEHkAOfrz9jLsT1R0XQXlnh5YaeqMSAWRF bDBmdPZAG/gmraXhNousPyNsrThEeZ+p7/uFgb/bUHa9JnRTksTbosVSUykSN6IYBwa/ s2QXHOSave5XgvVSBmhdBzR61DOxGIShYl4X2e/mFmpnKsLpQziqoYQdExj6hGfG+1W0 vMDVcGGENjumjT8CjiS8fXRF4Hel7gpW1ogFiGsWxjfAoFN9LpMOjkoSTDDhEwryTbiD sGWuLkLzfB5w3X9UXX4Phj7PfRQhV4mtZTwtK6Bra9IbSMxv7CVl+tc1KDOsaz3gh2mA Hg== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2q3uauvenm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jan 2019 21:14:57 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x0NLEuhf003426 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jan 2019 21:14:56 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x0NLEt4q020954; Wed, 23 Jan 2019 21:14:55 GMT Received: from char.us.oracle.com (/10.152.32.25) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 23 Jan 2019 13:14:55 -0800 Received: by char.us.oracle.com (Postfix, from userid 1000) id E60BB6A0120; Wed, 23 Jan 2019 16:14:53 -0500 (EST) Date: Wed, 23 Jan 2019 16:14:53 -0500 From: Konrad Rzeszutek Wilk To: "Michael S. Tsirkin" Cc: Joerg Roedel , Jason Wang , Christoph Hellwig , Jens Axboe , virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jfehlig@suse.com, jon.grimm@amd.com, brijesh.singh@amd.com, jroedel@suse.de Subject: Re: [PATCH 0/5 v3] Fix virtio-blk issue with SWIOTLB Message-ID: <20190123211453.GA2474@char.us.oracle.com> References: <20190123163049.24863-1-joro@8bytes.org> <20190123135000-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190123135000-mutt-send-email-mst@kernel.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9145 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901230154 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 23, 2019 at 01:51:29PM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 05:30:44PM +0100, Joerg Roedel wrote: > > Hi, > > > > here is the third version of this patch-set. Previous > > versions can be found here: > > > > V1: https://lore.kernel.org/lkml/20190110134433.15672-1-joro@8bytes.org/ > > > > V2: https://lore.kernel.org/lkml/20190115132257.6426-1-joro@8bytes.org/ > > > > The problem solved here is a limitation of the SWIOTLB implementation, > > which does not support allocations larger than 256kb. When the > > virtio-blk driver tries to read/write a block larger than that, the > > allocation of the dma-handle fails and an IO error is reported. > > > OK looks good to me. > I will park this in my tree for now this way it will get > testing in linux-next. > Can I get an ack from DMA maintainers on the DMA bits for > merging this in 5.0? You got mine (SWIOTBL is my area). > > > Changes to v2 are: > > > > * Check if SWIOTLB is active before returning its limit in > > dma_direct_max_mapping_size() > > > > * Only apply the maximum segment limit in virtio-blk when > > DMA-API is used for the vring > > > > Please review. > > > > Thanks, > > > > Joerg > > > > Joerg Roedel (5): > > swiotlb: Introduce swiotlb_max_mapping_size() > > swiotlb: Add is_swiotlb_active() function > > dma: Introduce dma_max_mapping_size() > > virtio: Introduce virtio_max_dma_size() > > virtio-blk: Consider virtio_max_dma_size() for maximum segment size > > > > drivers/block/virtio_blk.c | 10 ++++++---- > > drivers/virtio/virtio_ring.c | 10 ++++++++++ > > include/linux/dma-mapping.h | 16 ++++++++++++++++ > > include/linux/swiotlb.h | 11 +++++++++++ > > include/linux/virtio.h | 2 ++ > > kernel/dma/direct.c | 11 +++++++++++ > > kernel/dma/swiotlb.c | 10 ++++++++++ > > 7 files changed, 66 insertions(+), 4 deletions(-) > > > > -- > > 2.17.1