From: Dmitry Torokhov <firstname.lastname@example.org> To: Laurent Pinchart <email@example.com> Cc: "Lukas Wunner" <firstname.lastname@example.org>, "Ronald Tschalär" <email@example.com>, "Andrzej Hajda" <firstname.lastname@example.org>, "Inki Dae" <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it. Date: Wed, 23 Jan 2019 14:21:05 -0800 [thread overview] Message-ID: <20190123222105.GF179701@dtor-ws> (raw) In-Reply-To: <20190123221735.GE4675@pendragon.ideasonboard.com> Hi Laurent, On Thu, Jan 24, 2019 at 12:17:35AM +0200, Laurent Pinchart wrote: > Hello Dmity, > > On Wed, Jan 23, 2019 at 02:03:42PM -0800, Dmitry Torokhov wrote: > > On Wed, Jan 23, 2019 at 09:45:56AM +0100, Lukas Wunner wrote: > > > On Tue, Jan 22, 2019 at 06:13:11AM -0800, Ronald Tschalär wrote: > > >> commit d6abe6df706c66d803e6dd4fe98c1b6b7f125a56 (drm/bridge: > > >> sil_sii8620: do not have a dependency of RC_CORE) added a dependency on > > >> INPUT. However, this causes problems with other drivers, in particular > > >> an input driver that depends on MFD_INTEL_LPSS_PCI (to be added in a > > >> future commit): > > >> > > >> drivers/clk/Kconfig:9:error: recursive dependency detected! > > >> drivers/clk/Kconfig:9: symbol COMMON_CLK is selected by MFD_INTEL_LPSS > > >> drivers/mfd/Kconfig:566: symbol MFD_INTEL_LPSS is selected by MFD_INTEL_LPSS_PCI > > >> drivers/mfd/Kconfig:580: symbol MFD_INTEL_LPSS_PCI is implied by KEYBOARD_APPLESPI > > >> drivers/input/keyboard/Kconfig:73: symbol KEYBOARD_APPLESPI depends on INPUT > > >> drivers/input/Kconfig:8: symbol INPUT is selected by DRM_SIL_SII8620 > > >> drivers/gpu/drm/bridge/Kconfig:83: symbol DRM_SIL_SII8620 depends on DRM_BRIDGE > > >> drivers/gpu/drm/bridge/Kconfig:1: symbol DRM_BRIDGE is selected by DRM_PL111 > > >> drivers/gpu/drm/pl111/Kconfig:1: symbol DRM_PL111 depends on COMMON_CLK > > >> > > >> According to the docs, select should only be used for non-visible > > >> symbols. Furthermore almost all other references to INPUT throughout the > > >> kernel config are depends, not selects. Hence this change. > > > > I think this is not as cut and dry. We should be able to select needed > > subsystems (such as INPUT, USB, etc) even if they are user visible. > > Semantically, maybe, but given the current state of Kconfig this results > in a recursive dependencies nightmare. It's a no-go. > > > User, when enabling a piece of hardware, does not need to know ultimate > > details of all subsystems the driver might need ti function. > > > > It looks like one of the drivers implies MFD_INTEL_LPSS_PCI, maybe > > treating imply the same as select when detecting circular dependency is > > wrong as we are allowed to deselect implied dependencies? > > > > >> > > >> CC: Inki Dae <email@example.com> > > >> CC: Andrzej Hajda <firstname.lastname@example.org> > > >> Signed-off-by: Ronald Tschalär <email@example.com> > > > > > > Reviewed-by: Lukas Wunner <firstname.lastname@example.org> > > > > > > I think this needs to be merged through the input tree as a prerequisite > > > for the applespi.c driver (keyboard + touchpad driver for 2015+ MacBook, > > > MacBook Air and MacBook Pro which uses SPI instead of USB) to avoid > > > breaking the build. Adding Dmitry. > > > > I have no idea what applespi.c is (it is definitely not in my tree), so > > I think it should be merged through the same tree that the original > > commit was introduced through. > > > > >> --- > > >> drivers/gpu/drm/bridge/Kconfig | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > >> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > > >> index 2fee47b0d50b..eabedc83f25c 100644 > > >> --- a/drivers/gpu/drm/bridge/Kconfig > > >> +++ b/drivers/gpu/drm/bridge/Kconfig > > >> @@ -83,9 +83,9 @@ config DRM_PARADE_PS8622 > > >> config DRM_SIL_SII8620 > > >> tristate "Silicon Image SII8620 HDMI/MHL bridge" > > >> depends on OF > > >> + depends on INPUT > > >> select DRM_KMS_HELPER > > >> imply EXTCON > > >> - select INPUT > > >> select RC_CORE > > > > Keeping "select RC_CORE" is wrong though, as the driver appears to be > > working find without RC. Maybe it should be stubbed out? > > It should definitely not be select'ed as it's a user-visible symbol. My > preference would be to simply revert d6abe6df706c. If we want (and can) > work without RC core then it should be stubbed out. > > Commit d6abe6df706c states > > And some boards not using remote controller device don't really > need to know that RC_CORE config should be enabled to use sil_sii8620 > driver only for HDMI. > > The same reasoning applies to INPUT, if we agree that depending on > RC_CORE is confusing for users, then depending on INPUT is confusing as > well. There's not reason to apply different standards to INPUT and > RC_CORE, depending on one and selecting the other doesn't make much > sense. OK, so revert + patch to stub out RC calls? That works for me (and I still say it should go through the same tree that introduced d6abe6df706c). Thanks. -- Dmitry
next prev parent reply other threads:[~2019-01-23 22:21 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-22 14:13 Ronald Tschalär 2019-01-22 21:10 ` Laurent Pinchart 2019-01-24 7:23 ` Life is hard, and then you die 2019-01-23 8:45 ` Lukas Wunner 2019-01-23 22:03 ` Dmitry Torokhov 2019-01-23 22:17 ` Laurent Pinchart 2019-01-23 22:21 ` Dmitry Torokhov [this message] 2019-01-23 22:22 ` Laurent Pinchart 2019-01-24 7:21 ` Life is hard, and then you die 2019-01-24 8:24 ` [PATCH v2] drm/bridge: sil_sii8620: make remote control optional Ronald Tschalär 2019-01-24 9:13 ` [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it Lukas Wunner 2019-01-25 1:33 ` [PATCH v2] drm/bridge: sil_sii8620: make remote control optional Ronald Tschalär 2019-01-28 10:53 ` Andrzej Hajda 2019-03-28 1:07 ` Life is hard, and then you die 2019-03-04 2:13 ` Life is hard, and then you die 2019-03-04 7:13 ` Andrzej Hajda 2019-04-07 1:30 ` [PATCH v3] " Ronald Tschalär
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190123222105.GF179701@dtor-ws \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).