From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: Antoine Tenart <antoine.tenart@bootlin.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"sd@queasysnail.net" <sd@queasysnail.net>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"quentin.schulz@bootlin.com" <quentin.schulz@bootlin.com>,
"allan.nielsen@microchip.com" <allan.nielsen@microchip.com>
Subject: Re: [PATCH net-next 06/10] net: introduce a net_device_ops macsec helper
Date: Thu, 24 Jan 2019 16:05:48 +0100 [thread overview]
Message-ID: <20190124150548.GG3662@kwain> (raw)
In-Reply-To: <f9b58195-9345-ab13-87b2-2c261aa89b58@aquantia.com>
Hi Igor,
On Thu, Jan 24, 2019 at 02:58:45PM +0000, Igor Russkikh wrote:
>
> Its great to see macsec hw offload infrastructure happening!
>
> > @@ -1441,6 +1445,10 @@ struct net_device_ops {
> > u32 flags);
> > int (*ndo_xsk_async_xmit)(struct net_device *dev,
> > u32 queue_id);
> > +#ifdef CONFIG_MACSEC
> > + int (*ndo_macsec)(struct net_device *dev,
> > + struct netdev_macsec *macsec);
> > +#endif
> > };
>
> Most of ndo's are named by action verbs. This ndo is abit misleading, reader
> may have difficulties understanding what
>
> + if (phydev->drv->macsec)
> + ret = phydev->drv->macsec(phydev, macsec);
>
> is actually doing.
>
> May be it'd be better renaming to at least ndo_do_macsec(), or ndo_setup_macsec()
> ?
>
> Similar comment is for
>
> +struct netdev_macsec {
>
> It reads like a macsec device context, but it is a macsec configuration command.
OK, I'll rename the functions so that they contain a verb.
Thanks!
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-01-24 15:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 15:56 [PATCH net-next 00/10] net: macsec: initial support for hardware offloading Antoine Tenart
2019-01-23 15:56 ` [PATCH net-next 01/10] net: introduce the MACSEC netdev feature Antoine Tenart
2019-01-23 15:56 ` [PATCH net-next 02/10] net: macsec: convert to SPDX Antoine Tenart
2019-01-23 17:03 ` Andrew Lunn
2019-01-24 8:54 ` Antoine Tenart
2019-01-24 13:11 ` Andrew Lunn
2019-01-24 13:29 ` Antoine Tenart
2019-01-23 15:56 ` [PATCH net-next 03/10] net: macsec: move some definitions in a dedicated header Antoine Tenart
2019-01-23 20:11 ` Florian Fainelli
2019-01-24 1:00 ` David Miller
2019-01-24 8:58 ` Antoine Tenart
2019-01-23 15:56 ` [PATCH net-next 04/10] net: macsec: introduce the netdev_macsec structure Antoine Tenart
2019-01-23 15:56 ` [PATCH net-next 05/10] net: phy: introduce a phy_driver macsec helper Antoine Tenart
2019-01-23 17:08 ` Andrew Lunn
2019-01-24 8:56 ` Antoine Tenart
2019-01-23 15:56 ` [PATCH net-next 06/10] net: introduce a net_device_ops " Antoine Tenart
2019-01-23 20:16 ` Florian Fainelli
2019-01-24 9:23 ` Antoine Tenart
2019-01-31 9:26 ` Antoine Tenart
2019-02-01 3:50 ` Florian Fainelli
2019-01-24 14:58 ` Igor Russkikh
2019-01-24 15:05 ` Antoine Tenart [this message]
2019-01-23 15:56 ` [PATCH net-next 07/10] net: macsec: hardware offloading infrastructure Antoine Tenart
2019-01-23 15:56 ` [PATCH net-next 08/10] net: phy: export __phy_read_page/__phy_write_page Antoine Tenart
2019-01-23 15:56 ` [PATCH net-next 09/10] net: phy: mscc: macsec initialization Antoine Tenart
2019-01-23 15:56 ` [PATCH net-next 10/10] net: phy: mscc: macsec support Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124150548.GG3662@kwain \
--to=antoine.tenart@bootlin.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin.schulz@bootlin.com \
--cc=sd@queasysnail.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).