From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938E7C282C3 for ; Thu, 24 Jan 2019 19:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58201218D4 for ; Thu, 24 Jan 2019 19:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548357732; bh=vJgUr2O7tUGo8nWlqqK1QKISjabhb9kc0ARRSPcFOQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sV9xjQqGJxMIc96HgfhIm0GOlVlzITAG42MzkDp5uwqqh4T2oQjo9WbLpaKajbCvq ld2tnO7aNMUMjZfvxgVG65/fqyBqDKpSVaVNyrIw08jrDE0LydykA3JjQaAM0BDE9Z zY/8W6psdmbdtUgx5eXyUo/ddAZC3V9yb19a8RgU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729466AbfAXTWL (ORCPT ); Thu, 24 Jan 2019 14:22:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:46656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729436AbfAXTWK (ORCPT ); Thu, 24 Jan 2019 14:22:10 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09F6F218CD; Thu, 24 Jan 2019 19:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548357729; bh=vJgUr2O7tUGo8nWlqqK1QKISjabhb9kc0ARRSPcFOQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nBts2jnCgutUwMh/3ZP8tIv1wOyEL/3Wn9DinU+OoZvVNfZmq5OjbmY5HMdNpov8s ici1pfhGp2IPmyCq7TWOVx/nGuEb9/k8sEqIi0zeuPJPZtyrIYaUgZ/BDj6FWk6lsR y3QK9FvxW1+MuxfZTPvEADNrUiJa29vWkyGKJc5o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavel Shilovsky , Jeff Layton , Steve French Subject: [PATCH 3.18 02/52] CIFS: Do not hide EINTR after sending network packets Date: Thu, 24 Jan 2019 20:19:26 +0100 Message-Id: <20190124190141.276805366@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124190140.879495253@linuxfoundation.org> References: <20190124190140.879495253@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pavel Shilovsky commit ee13919c2e8d1f904e035ad4b4239029a8994131 upstream. Currently we hide EINTR code returned from sock_sendmsg() and return 0 instead. This makes a caller think that we successfully completed the network operation which is not true. Fix this by properly returning EINTR to callers. Cc: Signed-off-by: Pavel Shilovsky Reviewed-by: Jeff Layton Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/cifs/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -360,7 +360,7 @@ uncork: if (rc < 0 && rc != -EINTR) cifs_dbg(VFS, "Error %d sending data on socket to server\n", rc); - else + else if (rc > 0) rc = 0; return rc;