From: Sean Paul <sean@poorly.run>
To: Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org,
Alexey Brodkin <abrodkin@synopsys.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Chen Feng <puck.chen@hisilicon.com>,
David Airlie <airlied@linux.ie>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Philippe Cornu <philippe.cornu@st.com>,
Rongrong Zou <zourongrong@gmail.com>, Sean Paul <sean@poorly.run>,
Vincent Abriou <vincent.abriou@st.com>,
Xinliang Liu <z.liuxinliang@hisilicon.com>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
Yannick Fertre <yannick.fertre@st.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 6/6] drm: remove drmP.h from drm_modeset_helper.h
Date: Thu, 24 Jan 2019 15:07:47 -0500 [thread overview]
Message-ID: <20190124200747.GQ114153@art_vandelay> (raw)
In-Reply-To: <20190124140320.GY3271@phenom.ffwll.local>
On Thu, Jan 24, 2019 at 03:03:20PM +0100, Daniel Vetter wrote:
> On Sat, Jan 19, 2019 at 09:40:14AM +0100, Sam Ravnborg wrote:
> > With the removal of drmP.h from drm_modeset_helper.h
> > the drmP.h are no longer included by any include files
> > in include/drm.
> > The drmP.h file is thus only included explicit
> > either in .c files or in local .h files.
> > This makes the process of deleting the drmP.h includes easier
> > as we have a more local dependency chain.
> >
> > Include build failure fixes in drm files after the drmP.h removal.
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
>
> Merge the previous 5 patches from this series, but this now goes boom on
> vbox in staging. Needs another prep patch I think.
Soo, can we drop vboxvideo yet?
Sean
> -Daniel
>
> > ---
> > drivers/gpu/drm/drm_damage_helper.c | 1 +
> > drivers/gpu/drm/drm_modeset_helper.c | 2 ++
> > include/drm/drm_modeset_helper.h | 6 +++++-
> > 3 files changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_damage_helper.c b/drivers/gpu/drm/drm_damage_helper.c
> > index e16aa5ae00b4..ee67c96841fa 100644
> > --- a/drivers/gpu/drm/drm_damage_helper.c
> > +++ b/drivers/gpu/drm/drm_damage_helper.c
> > @@ -32,6 +32,7 @@
> >
> > #include <drm/drm_atomic.h>
> > #include <drm/drm_damage_helper.h>
> > +#include <drm/drm_device.h>
> >
> > /**
> > * DOC: overview
> > diff --git a/drivers/gpu/drm/drm_modeset_helper.c b/drivers/gpu/drm/drm_modeset_helper.c
> > index 9150fa385bba..9bc1ef788c77 100644
> > --- a/drivers/gpu/drm/drm_modeset_helper.c
> > +++ b/drivers/gpu/drm/drm_modeset_helper.c
> > @@ -23,8 +23,10 @@
> > #include <drm/drm_atomic_helper.h>
> > #include <drm/drm_crtc_helper.h>
> > #include <drm/drm_fb_helper.h>
> > +#include <drm/drm_fourcc.h>
> > #include <drm/drm_modeset_helper.h>
> > #include <drm/drm_plane_helper.h>
> > +#include <drm/drm_print.h>
> >
> > /**
> > * DOC: aux kms helpers
> > diff --git a/include/drm/drm_modeset_helper.h b/include/drm/drm_modeset_helper.h
> > index efa337f03129..995fd981cab0 100644
> > --- a/include/drm/drm_modeset_helper.h
> > +++ b/include/drm/drm_modeset_helper.h
> > @@ -23,7 +23,11 @@
> > #ifndef __DRM_KMS_HELPER_H__
> > #define __DRM_KMS_HELPER_H__
> >
> > -#include <drm/drmP.h>
> > +struct drm_crtc;
> > +struct drm_crtc_funcs;
> > +struct drm_device;
> > +struct drm_framebuffer;
> > +struct drm_mode_fb_cmd2;
> >
> > void drm_helper_move_panel_connectors_to_head(struct drm_device *);
> >
> > --
> > 2.12.0
> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2019-01-24 20:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 8:40 [PATCH v5 0/6] drm: minimize drmP.h dependencies Sam Ravnborg
2019-01-19 8:40 ` [PATCH v5 1/6] drm/stm: prepare for drmP.h removal from drm_modeset_helper.h Sam Ravnborg
2019-01-19 8:40 ` [PATCH v5 2/6] drm/hisilicon/kirin: " Sam Ravnborg
2019-01-19 8:40 ` [PATCH v5 3/6] drm/arcpgu: " Sam Ravnborg
2019-01-19 8:40 ` [PATCH v5 4/6] drm/bridge: cdns: " Sam Ravnborg
2019-01-19 8:40 ` [PATCH v5 5/6] drmi/rcar-du: " Sam Ravnborg
2019-01-19 8:40 ` [PATCH v5 6/6] drm: remove drmP.h " Sam Ravnborg
2019-01-24 14:03 ` Daniel Vetter
2019-01-24 14:44 ` Sam Ravnborg
2019-01-24 20:07 ` Sean Paul [this message]
2019-01-24 20:17 ` Sam Ravnborg
2019-01-24 20:28 ` Sean Paul
2019-01-24 21:52 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124200747.GQ114153@art_vandelay \
--to=sean@poorly.run \
--cc=a.hajda@samsung.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@linux.ie \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=philippe.cornu@st.com \
--cc=puck.chen@hisilicon.com \
--cc=sam@ravnborg.org \
--cc=vincent.abriou@st.com \
--cc=yannick.fertre@st.com \
--cc=z.liuxinliang@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).