From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: vivien.didelot@gmail.com, Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE)
Subject: [PATCH] of: Make of_node_name_eq() case insensitive
Date: Thu, 24 Jan 2019 12:08:25 -0800 [thread overview]
Message-ID: <20190124200825.2611-1-f.fainelli@gmail.com> (raw)
Since c32569e358ad ("regulator: Use of_node_name_eq for node name
comparisons") Vivien reported the mc13892-regulator complaining about
not being able to find regulators.
This is because prior to that commit we used of_node_cmp() to compare
the regulator array passed from mc13892_regulators down to
mc13xxx_parse_regulators_dt() and they are all defined in uppercase
letters by the MC13892_*_DEFINE* macros, whereas they are defined as
lowercase in the DTS.
Fix this by use strncasecmp() since that makes sure the comparison is
case insensitive like what of_node_cmp() did.
Reported-by: Vivien Didelot <vivien.didelot@gmail.com>
Fixes: c32569e358ad ("regulator: Use of_node_name_eq for node name comparisons")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/of/base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 5226e898476e..ff47c86277cb 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -66,7 +66,8 @@ bool of_node_name_eq(const struct device_node *np, const char *name)
node_name = kbasename(np->full_name);
len = strchrnul(node_name, '@') - node_name;
- return (strlen(name) == len) && (strncmp(node_name, name, len) == 0);
+ return (strlen(name) == len) &&
+ (strncasecmp(node_name, name, len) == 0);
}
EXPORT_SYMBOL(of_node_name_eq);
--
2.17.1
next reply other threads:[~2019-01-24 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 20:08 Florian Fainelli [this message]
2019-01-24 20:14 ` [PATCH] of: Make of_node_name_eq() case insensitive Joe Perches
2019-01-24 20:19 ` Vivien Didelot
2019-01-24 23:45 ` Frank Rowand
2019-01-25 1:20 ` Florian Fainelli
2019-01-25 2:06 ` Frank Rowand
2019-01-25 5:00 ` Florian Fainelli
2019-01-25 15:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124200825.2611-1-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).