From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1AE2C282C3 for ; Thu, 24 Jan 2019 21:08:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A993A218B0 for ; Thu, 24 Jan 2019 21:08:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727809AbfAXVIE (ORCPT ); Thu, 24 Jan 2019 16:08:04 -0500 Received: from mga11.intel.com ([192.55.52.93]:26608 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbfAXVIE (ORCPT ); Thu, 24 Jan 2019 16:08:04 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2019 13:08:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,518,1539673200"; d="scan'208";a="141073644" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga001.fm.intel.com with ESMTP; 24 Jan 2019 13:08:01 -0800 Received: from andy by smile with local (Exim 4.92-RC4) (envelope-from ) id 1gmmEB-0005QQ-S1; Thu, 24 Jan 2019 23:07:59 +0200 Date: Thu, 24 Jan 2019 23:07:59 +0200 From: Andy Shevchenko To: Phil Edworthy Cc: Michael Turquette , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Stephen Boyd , Russell King , Geert Uytterhoeven , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v9 1/2] clk: Add comment about __of_clk_get_by_name() error values Message-ID: <20190124210759.GM9224@smile.fi.intel.com> References: <20181203111309.3709-1-phil.edworthy@renesas.com> <20181203111309.3709-2-phil.edworthy@renesas.com> <20181203133040.GN10650@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 16, 2019 at 03:18:42PM +0000, Phil Edworthy wrote: > Hi, > > Any other comments on this patch and patch 2/2 (https://lkml.org/lkml/2018/12/3/326)? Was on vacations, sorry. > > > I would start new sentence from new line (this will emphasize the > > > possible > > > variants) > > > > > > * This is ... > > I disagree, the explanation is specifically related to the case where the > > function returns -EINVAL. Though this is a nit, so I'm not really bothered > > either way. Ah, okay. You may bear my tags on. -- With Best Regards, Andy Shevchenko