From: Johan Hovold <johan@kernel.org>
To: Loys Ollivier <lollivier@baylibre.com>
Cc: devicetree@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v2 2/4] dt-bindings: gnss: add mediatek binding
Date: Fri, 25 Jan 2019 10:07:55 +0100 [thread overview]
Message-ID: <20190125090755.GB3691@localhost> (raw)
In-Reply-To: <1547744074-28308-3-git-send-email-lollivier@baylibre.com>
On Thu, Jan 17, 2019 at 05:54:32PM +0100, Loys Ollivier wrote:
> Add binding for Mediatek-based GNSS receivers.
>
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
> ---
>
> v2:
> Renamed bindings from Globaltop/gtop to Mediatek/mtk.
> Moved current-speed as an optional propertie.
> Removed the status line in the example.
> Added "mediatek,mt3339" compatible.
>
> .../devicetree/bindings/gnss/mediatek.txt | 39 ++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gnss/mediatek.txt
>
> diff --git a/Documentation/devicetree/bindings/gnss/mediatek.txt b/Documentation/devicetree/bindings/gnss/mediatek.txt
> new file mode 100644
> index 000000000000..fd984b4a9a6d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gnss/mediatek.txt
> @@ -0,0 +1,39 @@
> +Mediatek-based GNSS Receiver DT binding
> +
> +Mediatek chipsets are used in GNSS-receiver modules produced by several
> +vendors and can use UART, SPI or I2C interfaces.
> +
> +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic
> +properties.
> +
> +Required properties:
> +
> +- compatible : Must be one of
> +
> + "globaltop,pa6h"
> + "mediatek,mt3339"
I'm not sure it makes sense to add the GPS chip itself as it cannot be
used stand-alone AFAIU, and either not way would require a lot more
resources to be defined than what you add to this binding.
> +
> +- vcc-supply : Main voltage regulator (pin name: 3V3_IN, VCC, VDD)
The pin names in parenthesis were copied from the sirf-star binding and
were used to capture the various names given to this supply by different
vendors. Please drop as it doesn't apply here.
> +
> +Required properties (I2C):
> +- reg : I2C slave address
> +
> +Required properties (SPI):
> +- reg : SPI chip select address
While the mt3339 appears to support these interfaces, the globaltop one
does not.
Have you looked around for a small sample of mt3339-based receivers, to
see whether anyone actually provides these?
> +Optional properties:
> +
> +- timepulse-gpios : Time pulse GPIO
> +- v-bckp-supply : Backup voltage regulator
> +- current-speed : Default UART baud rate
Looks like you forgot the optional NRESET input and 3D-FIX output (even
if the latter might be of limited use).
> +
> +Example:
> +
> +serial@1234 {
> + compatible = "ns16550a";
> +
> + gnss {
> + compatible = "globaltop,pa6h";
> + vcc-supply = <&vcc_3v3>;
> + };
> +};
Johan
next prev parent reply other threads:[~2019-01-25 9:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 16:54 [PATCH v2 0/4] Add driver for Mediatek-based GNSS receivers Loys Ollivier
2019-01-17 16:54 ` [PATCH v2 1/4] dt-bindings: Add vendor prefix for "GlobalTop Technology, Inc." Loys Ollivier
2019-01-21 17:09 ` Rob Herring
2019-01-17 16:54 ` [PATCH v2 2/4] dt-bindings: gnss: add mediatek binding Loys Ollivier
2019-01-21 17:10 ` Rob Herring
2019-01-21 17:27 ` Loys Ollivier
2019-01-21 18:44 ` Sean Wang
2019-01-22 8:47 ` Loys Ollivier
2019-01-22 10:25 ` Sean Wang
2019-01-21 21:51 ` Rob Herring
2019-01-22 8:49 ` Loys Ollivier
2019-01-25 9:07 ` Johan Hovold [this message]
2019-01-28 15:46 ` Loys Ollivier
2019-02-11 8:33 ` Johan Hovold
2019-02-11 14:17 ` Loys Ollivier
2019-02-13 15:22 ` Loys Ollivier
2019-02-13 15:24 ` Loys Ollivier
2019-02-14 9:11 ` Johan Hovold
2019-02-15 12:10 ` Loys Ollivier
2019-02-15 16:00 ` Johan Hovold
2019-01-17 16:54 ` [PATCH v2 3/4] gnss: add mtk receiver type support Loys Ollivier
2019-01-25 9:12 ` Johan Hovold
2019-01-17 16:54 ` [PATCH v2 4/4] gnss: add driver for mediatek receivers Loys Ollivier
2019-01-25 9:30 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125090755.GB3691@localhost \
--to=johan@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lollivier@baylibre.com \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).