From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA28C282C0 for ; Fri, 25 Jan 2019 13:46:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91CEA218D0 for ; Fri, 25 Jan 2019 13:46:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728624AbfAYNqD (ORCPT ); Fri, 25 Jan 2019 08:46:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53320 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfAYNqC (ORCPT ); Fri, 25 Jan 2019 08:46:02 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A285A37EEA; Fri, 25 Jan 2019 13:46:02 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.163]) by smtp.corp.redhat.com (Postfix) with SMTP id 3C68D177CE; Fri, 25 Jan 2019 13:46:01 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 25 Jan 2019 14:46:01 +0100 (CET) Date: Fri, 25 Jan 2019 14:46:00 +0100 From: Oleg Nesterov To: Roman Gushchin Cc: Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Roman Gushchin Subject: Re: [PATCH v6 4/7] cgroup: cgroup v2 freezer Message-ID: <20190125134600.GB18991@redhat.com> References: <20181222000307.28231-1-guro@fb.com> <20181222000307.28231-5-guro@fb.com> <20190125122713.GA18218@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190125122713.GA18218@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 25 Jan 2019 13:46:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25, Oleg Nesterov wrote: > > One of the task is killed, it calls leave_frozen(). If I read this code path > correctly, only ->nr_frozen_tasks will be decremented, so "frozen" will be > "false" when cgroup_update_frozen() is called. forgot to mention... and I do not think cgroup_exit() can "fix" this, see another email I sent a minute ago... Oleg.