From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C78F9C282C0 for ; Fri, 25 Jan 2019 17:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A017B218A2 for ; Fri, 25 Jan 2019 17:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729337AbfAYRqv (ORCPT ); Fri, 25 Jan 2019 12:46:51 -0500 Received: from mga04.intel.com ([192.55.52.120]:17614 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfAYRqv (ORCPT ); Fri, 25 Jan 2019 12:46:51 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2019 09:46:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,522,1539673200"; d="scan'208";a="119486938" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga008.fm.intel.com with ESMTP; 25 Jan 2019 09:46:47 -0800 Received: from andy by smile with local (Exim 4.92-RC4) (envelope-from ) id 1gn5Z0-0003Zg-Do; Fri, 25 Jan 2019 19:46:46 +0200 Date: Fri, 25 Jan 2019 19:46:46 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Hans de Goede , Mika Westerberg , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , "Rafael J. Wysocki" , ACPI Devel Maling List , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "linux-kernel@vger.kernel.org" Subject: Re: [RFT][PATCH v2] gpiolib: acpi: Introduce ACPI_GPIO_QUIRK_ONLY_GPIOIO Message-ID: <20190125174646.GS9224@smile.fi.intel.com> References: <20190109105245.25954-1-andriy.shevchenko@linux.intel.com> <20190125174442.GR9224@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190125174442.GR9224@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 25, 2019 at 07:44:42PM +0200, Andy Shevchenko wrote: > On Mon, Jan 21, 2019 at 02:03:09PM +0100, Linus Walleij wrote: > > On Wed, Jan 9, 2019 at 11:52 AM Andy Shevchenko > > wrote: > > > > > New quirk enforces search for GPIO based on its type, > > > i.e. iterate over GpioIo resources only. > > > > > > Signed-off-by: Andy Shevchenko > > > --- > > > > > > - it was sent few weeks ago to Hans for testing, but better to re-test > > > - it's supposed to go via ASoC subsystem due to recent changes made for > > > sound driver > > > > > > v2: > > > - Expand explanation why this quirk might be needed (Mika) > > > > I tried to apply this but it doesn't apply on the GPIO devel > > branch. > > > > I suppose because of Hans de Goede's > > commit 72893f0c6bd399ce84e3c1c9fc69d234fe37d098 > > Author: Hans de Goede > > Date: Mon Dec 31 21:55:21 2018 +0100 > > > > gpiolib-acpi: Preserve non direction flags when updating gpiod_flags > > > > Could you rebase and resend? > > Linus, as I mentioned in comments above this should go via ASoC tree, there is > no conflicts with gpio/devel for GPIO matters. > > So, please, give your Ack and hopefully Mark will apply this soon. Perhaps Mark can provide you an immutable branch to be merged. > > (Also pick up Mika's ACK.) > > > > PS I'm a bit split about pure ACPI patches, part of me see it as an > > "intel thing" so that you could very well collect it in the Intel > > GPIO tree and send me pull requests, on the other hand it is > > ACPI and sometimes applied in Rafael's tree. Maybe just as good > > that I keep picking them separately like this? I dunno. Let Mika speak up. -- With Best Regards, Andy Shevchenko