* [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup
@ 2019-01-26 9:51 Enric Balletbo i Serra
2019-01-26 9:51 ` [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier Enric Balletbo i Serra
` (11 more replies)
0 siblings, 12 replies; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel
Cc: groeck, gwendal, kernel, bleung, Colin Cross, Tony Luck,
Anton Vorontsov, Kees Cook
Hi,
After the patchset to move cros_ec sysfs attributes to its own drivers,
I'd like to do some cleanup and switch to the SPDX license on all the
platform/chrome drivers.
Best regards,
Enric
Changes in v2:
- Removed the patches that remove the unnused includes (were wrong).
- Add patches for all files in platform/chrome that didn't switch yet.
Enric Balletbo i Serra (12):
platform/chrome: cromeos_pstore: switch to SPDX identifier
platform/chrome: cros_ec_debugfs: switch to SPDX identifier
platform/chrome: cros_ec_lightbar: switch to SPDX identifier
platform/chrome: cros_ec_sysfs: switch to SPDX identifier
platform/chrome: cros_ec_vbc: switch to SPDX identifier
platform/chrome: cros_ec_i2c: switch to SPDX identifier
platform/chrome: cros_ec_lpc: switch to SPDX identifier
platform/chrome: cros_ec_proto: switch to SPDX identifier
platform/chrome: cros_ec_spi: switch to SPDX identifier
platform/chrome: cros_kbd_led_backlight: switch to SPDX identifier
platform/chrome: cros_ec_lightbar: remove pr_fmt() define
platform/chrome: cros_ec_sysfs: remove pr_fmt() define
drivers/platform/chrome/chromeos_pstore.c | 17 ++++------
drivers/platform/chrome/cros_ec_debugfs.c | 22 +++---------
drivers/platform/chrome/cros_ec_i2c.c | 22 ++++--------
drivers/platform/chrome/cros_ec_lightbar.c | 24 +++----------
drivers/platform/chrome/cros_ec_lpc.c | 34 +++++++------------
drivers/platform/chrome/cros_ec_lpc_mec.c | 26 +++-----------
drivers/platform/chrome/cros_ec_lpc_mec.h | 20 ++---------
drivers/platform/chrome/cros_ec_lpc_reg.c | 26 +++-----------
drivers/platform/chrome/cros_ec_lpc_reg.h | 20 ++---------
drivers/platform/chrome/cros_ec_proto.c | 19 +++--------
drivers/platform/chrome/cros_ec_spi.c | 20 +++--------
drivers/platform/chrome/cros_ec_sysfs.c | 26 +++-----------
drivers/platform/chrome/cros_ec_vbc.c | 24 +++----------
.../platform/chrome/cros_kbd_led_backlight.c | 19 +++--------
14 files changed, 67 insertions(+), 252 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:28 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 02/12] platform/chrome: cros_ec_debugfs: " Enric Balletbo i Serra
` (10 subsequent siblings)
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel
Cc: groeck, gwendal, kernel, bleung, Colin Cross, Tony Luck,
Anton Vorontsov, Kees Cook
Adopt the SPDX license identifier headers to ease license compliance
management. Also fix the module license mismatch and change the term
'Chrome OS' for 'ChromeOS' to be coherent with other drivers.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2:
- Removed the patches that removed the unnused includes (were wrong).
- Add patches for all files in platform/chrome that didn't switch yet.
drivers/platform/chrome/chromeos_pstore.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
index b0693fdec8c6..d13770785fb5 100644
--- a/drivers/platform/chrome/chromeos_pstore.c
+++ b/drivers/platform/chrome/chromeos_pstore.c
@@ -1,12 +1,7 @@
-/*
- * chromeos_pstore.c - Driver to instantiate Chromebook ramoops device
- *
- * Copyright (C) 2013 Google, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, version 2 of the License.
- */
+// SPDX-License-Identifier: GPL-2.0
+// Driver to instantiate Chromebook ramoops device.
+//
+// Copyright (C) 2013 Google, Inc.
#include <linux/acpi.h>
#include <linux/dmi.h>
@@ -138,5 +133,5 @@ static void __exit chromeos_pstore_exit(void)
module_init(chromeos_pstore_init);
module_exit(chromeos_pstore_exit);
-MODULE_DESCRIPTION("Chrome OS pstore module");
-MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("ChromeOS pstore module");
+MODULE_LICENSE("GPL v2");
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 02/12] platform/chrome: cros_ec_debugfs: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
2019-01-26 9:51 ` [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:28 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 03/12] platform/chrome: cros_ec_lightbar: " Enric Balletbo i Serra
` (9 subsequent siblings)
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_debugfs.c | 22 ++++------------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
index 6cacac53dfce..900c7073c46f 100644
--- a/drivers/platform/chrome/cros_ec_debugfs.c
+++ b/drivers/platform/chrome/cros_ec_debugfs.c
@@ -1,21 +1,7 @@
-/*
- * cros_ec_debugfs - debug logs for Chrome OS EC
- *
- * Copyright 2015 Google, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <http://www.gnu.org/licenses/>.
- */
+// SPDX-License-Identifier: GPL-2.0+
+// Debug logs for the ChromeOS EC
+//
+// Copyright (C) 2015 Google, Inc.
#include <linux/circ_buf.h>
#include <linux/debugfs.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 03/12] platform/chrome: cros_ec_lightbar: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
2019-01-26 9:51 ` [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier Enric Balletbo i Serra
2019-01-26 9:51 ` [PATCH v2 02/12] platform/chrome: cros_ec_debugfs: " Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:29 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 04/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
` (8 subsequent siblings)
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_lightbar.c | 22 ++++------------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
index c3e4e6e5211d..37689ad79544 100644
--- a/drivers/platform/chrome/cros_ec_lightbar.c
+++ b/drivers/platform/chrome/cros_ec_lightbar.c
@@ -1,21 +1,7 @@
-/*
- * cros_ec_lightbar - expose the Chromebook Pixel lightbar to userspace
- *
- * Copyright (C) 2014 Google, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <http://www.gnu.org/licenses/>.
- */
+// SPDX-License-Identifier: GPL-2.0+
+// Expose the Chromebook Pixel lightbar to userspace
+//
+// Copyright (C) 2014 Google, Inc.
#define pr_fmt(fmt) "cros_ec_lightbar: " fmt
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 04/12] platform/chrome: cros_ec_sysfs: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
` (2 preceding siblings ...)
2019-01-26 9:51 ` [PATCH v2 03/12] platform/chrome: cros_ec_lightbar: " Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:29 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 05/12] platform/chrome: cros_ec_vbc: " Enric Balletbo i Serra
` (7 subsequent siblings)
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
Adopt the SPDX license identifier headers to ease license compliance
management. Also change the description for one more appropriate.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_sysfs.c | 24 +++++-------------------
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
index 0ff5aa30c070..01c420727ee1 100644
--- a/drivers/platform/chrome/cros_ec_sysfs.c
+++ b/drivers/platform/chrome/cros_ec_sysfs.c
@@ -1,21 +1,7 @@
-/*
- * cros_ec_sysfs - expose the Chrome OS EC through sysfs
- *
- * Copyright (C) 2014 Google, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <http://www.gnu.org/licenses/>.
- */
+// SPDX-License-Identifier: GPL-2.0+
+// Expose the ChromeOS EC through sysfs
+//
+// Copyright (C) 2014 Google, Inc.
#define pr_fmt(fmt) "cros_ec_sysfs: " fmt
@@ -389,5 +375,5 @@ static struct platform_driver cros_ec_sysfs_driver = {
module_platform_driver(cros_ec_sysfs_driver);
MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("ChromeOS EC control driver");
+MODULE_DESCRIPTION("Expose the ChromeOS EC through sysfs");
MODULE_ALIAS("platform:" DRV_NAME);
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 05/12] platform/chrome: cros_ec_vbc: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
` (3 preceding siblings ...)
2019-01-26 9:51 ` [PATCH v2 04/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:30 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 06/12] platform/chrome: cros_ec_i2c: " Enric Balletbo i Serra
` (6 subsequent siblings)
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_vbc.c | 24 +++++-------------------
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_vbc.c b/drivers/platform/chrome/cros_ec_vbc.c
index af9bfe6f385c..8392a1ec33a7 100644
--- a/drivers/platform/chrome/cros_ec_vbc.c
+++ b/drivers/platform/chrome/cros_ec_vbc.c
@@ -1,22 +1,8 @@
-/*
- * cros_ec_vbc - Expose the vboot context nvram to userspace
- *
- * Copyright (C) 2015 Collabora Ltd.
- *
- * based on vendor driver,
- *
- * Copyright (C) 2012 The Chromium OS Authors
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
+// SPDX-License-Identifier: GPL-2.0+
+// Expose the vboot context nvram to userspace
+//
+// Copyright (C) 2012 Google, Inc.
+// Copyright (C) 2015 Collabora Ltd.
#include <linux/of.h>
#include <linux/platform_device.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 06/12] platform/chrome: cros_ec_i2c: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
` (4 preceding siblings ...)
2019-01-26 9:51 ` [PATCH v2 05/12] platform/chrome: cros_ec_vbc: " Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:31 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 07/12] platform/chrome: cros_ec_lpc: " Enric Balletbo i Serra
` (5 subsequent siblings)
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
Adopt the SPDX license identifier headers to ease license compliance
management. Also fix the module license mismatch and change the
description for a more descriptive phrase.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_i2c.c | 22 ++++++----------------
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_i2c.c b/drivers/platform/chrome/cros_ec_i2c.c
index 739b985c97e1..691744912dac 100644
--- a/drivers/platform/chrome/cros_ec_i2c.c
+++ b/drivers/platform/chrome/cros_ec_i2c.c
@@ -1,17 +1,7 @@
-/*
- * ChromeOS EC multi-function device (I2C)
- *
- * Copyright (C) 2012 Google, Inc
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
+// SPDX-License-Identifier: GPL-2.0+
+// I2C interface for ChromeOS Embedded Controller
+//
+// Copyright (C) 2012 Google, Inc
#include <linux/acpi.h>
#include <linux/delay.h>
@@ -373,5 +363,5 @@ static struct i2c_driver cros_ec_driver = {
module_i2c_driver(cros_ec_driver);
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("ChromeOS EC multi function device");
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("I2C interface for ChromeOS Embedded Controller");
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 07/12] platform/chrome: cros_ec_lpc: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
` (5 preceding siblings ...)
2019-01-26 9:51 ` [PATCH v2 06/12] platform/chrome: cros_ec_i2c: " Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:33 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 08/12] platform/chrome: cros_ec_proto: " Enric Balletbo i Serra
` (4 subsequent siblings)
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
Adopt the SPDX license identifier headers to ease license compliance
management. Also remove the license boiler-plate and redundant driver
description.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_lpc.c | 34 ++++++++---------------
drivers/platform/chrome/cros_ec_lpc_mec.c | 26 +++--------------
drivers/platform/chrome/cros_ec_lpc_mec.h | 20 ++-----------
drivers/platform/chrome/cros_ec_lpc_reg.c | 26 +++--------------
drivers/platform/chrome/cros_ec_lpc_reg.h | 20 ++-----------
5 files changed, 24 insertions(+), 102 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
index 14684a56e40f..c9c240fbe7c6 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -1,25 +1,15 @@
-/*
- * cros_ec_lpc - LPC access to the Chrome OS Embedded Controller
- *
- * Copyright (C) 2012-2015 Google, Inc
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * This driver uses the Chrome OS EC byte-level message-based protocol for
- * communicating the keyboard state (which keys are pressed) from a keyboard EC
- * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
- * but everything else (including deghosting) is done here. The main
- * motivation for this is to keep the EC firmware as simple as possible, since
- * it cannot be easily upgraded and EC flash/IRAM space is relatively
- * expensive.
- */
+// SPDX-License-Identifier: GPL-2.0
+// LPC interface for ChromeOS Embedded Controller
+//
+// Copyright (C) 2012-2015 Google, Inc
+//
+// This driver uses the ChromeOS EC byte-level message-based protocol for
+// communicating the keyboard state (which keys are pressed) from a keyboard EC
+// to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
+// but everything else (including deghosting) is done here. The main
+// motivation for this is to keep the EC firmware as simple as possible, since
+// it cannot be easily upgraded and EC flash/IRAM space is relatively
+// expensive.
#include <linux/acpi.h>
#include <linux/dmi.h>
diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.c b/drivers/platform/chrome/cros_ec_lpc_mec.c
index c4edfa83e493..296554a82b83 100644
--- a/drivers/platform/chrome/cros_ec_lpc_mec.c
+++ b/drivers/platform/chrome/cros_ec_lpc_mec.c
@@ -1,25 +1,7 @@
-/*
- * cros_ec_lpc_mec - LPC variant I/O for Microchip EC
- *
- * Copyright (C) 2016 Google, Inc
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * This driver uses the Chrome OS EC byte-level message-based protocol for
- * communicating the keyboard state (which keys are pressed) from a keyboard EC
- * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
- * but everything else (including deghosting) is done here. The main
- * motivation for this is to keep the EC firmware as simple as possible, since
- * it cannot be easily upgraded and EC flash/IRAM space is relatively
- * expensive.
- */
+// SPDX-License-Identifier: GPL-2.0
+// LPC variant I/O for Microchip EC
+//
+// Copyright (C) 2016 Google, Inc
#include <linux/delay.h>
#include <linux/io.h>
diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.h b/drivers/platform/chrome/cros_ec_lpc_mec.h
index 105068c0e919..68b381f2eb50 100644
--- a/drivers/platform/chrome/cros_ec_lpc_mec.h
+++ b/drivers/platform/chrome/cros_ec_lpc_mec.h
@@ -1,24 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
- * cros_ec_lpc_mec - LPC variant I/O for Microchip EC
+ * LPC variant I/O for Microchip EC
*
* Copyright (C) 2016 Google, Inc
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * This driver uses the Chrome OS EC byte-level message-based protocol for
- * communicating the keyboard state (which keys are pressed) from a keyboard EC
- * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
- * but everything else (including deghosting) is done here. The main
- * motivation for this is to keep the EC firmware as simple as possible, since
- * it cannot be easily upgraded and EC flash/IRAM space is relatively
- * expensive.
*/
#ifndef __CROS_EC_LPC_MEC_H
diff --git a/drivers/platform/chrome/cros_ec_lpc_reg.c b/drivers/platform/chrome/cros_ec_lpc_reg.c
index fc23d535c404..72fc3f6bff90 100644
--- a/drivers/platform/chrome/cros_ec_lpc_reg.c
+++ b/drivers/platform/chrome/cros_ec_lpc_reg.c
@@ -1,25 +1,7 @@
-/*
- * cros_ec_lpc_reg - LPC access to the Chrome OS Embedded Controller
- *
- * Copyright (C) 2016 Google, Inc
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * This driver uses the Chrome OS EC byte-level message-based protocol for
- * communicating the keyboard state (which keys are pressed) from a keyboard EC
- * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
- * but everything else (including deghosting) is done here. The main
- * motivation for this is to keep the EC firmware as simple as possible, since
- * it cannot be easily upgraded and EC flash/IRAM space is relatively
- * expensive.
- */
+// SPDX-License-Identifier: GPL-2.0
+// LPC interface for ChromeOS Embedded Controller
+//
+// Copyright (C) 2016 Google, Inc
#include <linux/io.h>
#include <linux/mfd/cros_ec.h>
diff --git a/drivers/platform/chrome/cros_ec_lpc_reg.h b/drivers/platform/chrome/cros_ec_lpc_reg.h
index 1c12c38b306a..416fd2572182 100644
--- a/drivers/platform/chrome/cros_ec_lpc_reg.h
+++ b/drivers/platform/chrome/cros_ec_lpc_reg.h
@@ -1,24 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
- * cros_ec_lpc_reg - LPC access to the Chrome OS Embedded Controller
+ * LPC interface for ChromeOS Embedded Controller
*
* Copyright (C) 2016 Google, Inc
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * This driver uses the Chrome OS EC byte-level message-based protocol for
- * communicating the keyboard state (which keys are pressed) from a keyboard EC
- * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
- * but everything else (including deghosting) is done here. The main
- * motivation for this is to keep the EC firmware as simple as possible, since
- * it cannot be easily upgraded and EC flash/IRAM space is relatively
- * expensive.
*/
#ifndef __CROS_EC_LPC_REG_H
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 08/12] platform/chrome: cros_ec_proto: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
` (6 preceding siblings ...)
2019-01-26 9:51 ` [PATCH v2 07/12] platform/chrome: cros_ec_lpc: " Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:33 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 09/12] platform/chrome: cros_ec_spi: " Enric Balletbo i Serra
` (3 subsequent siblings)
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_proto.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
index d2ba662fc713..d259ff264e9d 100644
--- a/drivers/platform/chrome/cros_ec_proto.c
+++ b/drivers/platform/chrome/cros_ec_proto.c
@@ -1,18 +1,7 @@
-/*
- * ChromeOS EC communication protocol helper functions
- *
- * Copyright (C) 2015 Google, Inc
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- */
+// SPDX-License-Identifier: GPL-2.0
+// ChromeOS EC communication protocol helper functions
+//
+// Copyright (C) 2015 Google, Inc
#include <linux/mfd/cros_ec.h>
#include <linux/delay.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 09/12] platform/chrome: cros_ec_spi: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
` (7 preceding siblings ...)
2019-01-26 9:51 ` [PATCH v2 08/12] platform/chrome: cros_ec_proto: " Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:34 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 10/12] platform/chrome: cros_kbd_led_backlight: " Enric Balletbo i Serra
` (2 subsequent siblings)
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
Adopt the SPDX license identifier headers to ease license compliance
management. Also change the description for one more appropriate.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_spi.c | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
index 2be41e8afa47..b20fc4040396 100644
--- a/drivers/platform/chrome/cros_ec_spi.c
+++ b/drivers/platform/chrome/cros_ec_spi.c
@@ -1,17 +1,7 @@
-/*
- * ChromeOS EC multi-function device (SPI)
- *
- * Copyright (C) 2012 Google, Inc
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
+// SPDX-License-Identifier: GPL-2.0+
+// SPI interface for ChromeOS Embedded Controller
+//
+// Copyright (C) 2012 Google, Inc
#include <linux/delay.h>
#include <linux/kernel.h>
@@ -730,4 +720,4 @@ static struct spi_driver cros_ec_driver_spi = {
module_spi_driver(cros_ec_driver_spi);
MODULE_LICENSE("GPL v2");
-MODULE_DESCRIPTION("ChromeOS EC multi function device (SPI)");
+MODULE_DESCRIPTION("SPI interface for ChromeOS Embedded Controller");
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 10/12] platform/chrome: cros_kbd_led_backlight: switch to SPDX identifier
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
` (8 preceding siblings ...)
2019-01-26 9:51 ` [PATCH v2 09/12] platform/chrome: cros_ec_spi: " Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:35 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 11/12] platform/chrome: cros_ec_lightbar: remove pr_fmt() define Enric Balletbo i Serra
2019-01-26 9:51 ` [PATCH v2 12/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
Adopt the SPDX license identifier headers to ease license compliance
management. Also change the term 'Chrome OS' for 'ChromeOS' to be
coherent with other drivers.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
.../platform/chrome/cros_kbd_led_backlight.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/platform/chrome/cros_kbd_led_backlight.c
index ca3e4da852b4..aa409f0201fb 100644
--- a/drivers/platform/chrome/cros_kbd_led_backlight.c
+++ b/drivers/platform/chrome/cros_kbd_led_backlight.c
@@ -1,18 +1,7 @@
-/*
- * Keyboard backlight LED driver for Chrome OS.
- *
- * Copyright (C) 2012 Google, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
+// SPDX-License-Identifier: GPL-2.0+
+// Keyboard backlight LED driver for ChromeOS
+//
+// Copyright (C) 2012 Google, Inc.
#include <linux/acpi.h>
#include <linux/leds.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 11/12] platform/chrome: cros_ec_lightbar: remove pr_fmt() define
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
` (9 preceding siblings ...)
2019-01-26 9:51 ` [PATCH v2 10/12] platform/chrome: cros_kbd_led_backlight: " Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:36 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 12/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
This driver no longer has any pr_{level} messages. Remove the pr_fmt().
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_lightbar.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
index 37689ad79544..d30a6650b0b5 100644
--- a/drivers/platform/chrome/cros_ec_lightbar.c
+++ b/drivers/platform/chrome/cros_ec_lightbar.c
@@ -3,8 +3,6 @@
//
// Copyright (C) 2014 Google, Inc.
-#define pr_fmt(fmt) "cros_ec_lightbar: " fmt
-
#include <linux/ctype.h>
#include <linux/delay.h>
#include <linux/device.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 12/12] platform/chrome: cros_ec_sysfs: remove pr_fmt() define
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
` (10 preceding siblings ...)
2019-01-26 9:51 ` [PATCH v2 11/12] platform/chrome: cros_ec_lightbar: remove pr_fmt() define Enric Balletbo i Serra
@ 2019-01-26 9:51 ` Enric Balletbo i Serra
2019-01-28 19:36 ` Guenter Roeck
11 siblings, 1 reply; 25+ messages in thread
From: Enric Balletbo i Serra @ 2019-01-26 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: groeck, gwendal, kernel, bleung
This driver no longer has any pr_{level} messages. Remove the pr_fmt().
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v2: None
drivers/platform/chrome/cros_ec_sysfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
index 01c420727ee1..fe0b7614ae1b 100644
--- a/drivers/platform/chrome/cros_ec_sysfs.c
+++ b/drivers/platform/chrome/cros_ec_sysfs.c
@@ -3,8 +3,6 @@
//
// Copyright (C) 2014 Google, Inc.
-#define pr_fmt(fmt) "cros_ec_sysfs: " fmt
-
#include <linux/ctype.h>
#include <linux/delay.h>
#include <linux/device.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier Enric Balletbo i Serra
@ 2019-01-28 19:28 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:28 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel,
Benson Leung, Colin Cross, Tony Luck, Anton Vorontsov, Kees Cook
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also fix the module license mismatch and change the term
> 'Chrome OS' for 'ChromeOS' to be coherent with other drivers.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2:
> - Removed the patches that removed the unnused includes (were wrong).
> - Add patches for all files in platform/chrome that didn't switch yet.
>
> drivers/platform/chrome/chromeos_pstore.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
> index b0693fdec8c6..d13770785fb5 100644
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@ -1,12 +1,7 @@
> -/*
> - * chromeos_pstore.c - Driver to instantiate Chromebook ramoops device
> - *
> - * Copyright (C) 2013 Google, Inc.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation, version 2 of the License.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// Driver to instantiate Chromebook ramoops device.
> +//
> +// Copyright (C) 2013 Google, Inc.
>
> #include <linux/acpi.h>
> #include <linux/dmi.h>
> @@ -138,5 +133,5 @@ static void __exit chromeos_pstore_exit(void)
> module_init(chromeos_pstore_init);
> module_exit(chromeos_pstore_exit);
>
> -MODULE_DESCRIPTION("Chrome OS pstore module");
> -MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("ChromeOS pstore module");
> +MODULE_LICENSE("GPL v2");
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 02/12] platform/chrome: cros_ec_debugfs: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 02/12] platform/chrome: cros_ec_debugfs: " Enric Balletbo i Serra
@ 2019-01-28 19:28 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:28 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_debugfs.c | 22 ++++------------------
> 1 file changed, 4 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
> index 6cacac53dfce..900c7073c46f 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -1,21 +1,7 @@
> -/*
> - * cros_ec_debugfs - debug logs for Chrome OS EC
> - *
> - * Copyright 2015 Google, Inc.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program. If not, see <http://www.gnu.org/licenses/>.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +// Debug logs for the ChromeOS EC
> +//
> +// Copyright (C) 2015 Google, Inc.
>
> #include <linux/circ_buf.h>
> #include <linux/debugfs.h>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 03/12] platform/chrome: cros_ec_lightbar: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 03/12] platform/chrome: cros_ec_lightbar: " Enric Balletbo i Serra
@ 2019-01-28 19:29 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:29 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_lightbar.c | 22 ++++------------------
> 1 file changed, 4 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
> index c3e4e6e5211d..37689ad79544 100644
> --- a/drivers/platform/chrome/cros_ec_lightbar.c
> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
> @@ -1,21 +1,7 @@
> -/*
> - * cros_ec_lightbar - expose the Chromebook Pixel lightbar to userspace
> - *
> - * Copyright (C) 2014 Google, Inc.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program. If not, see <http://www.gnu.org/licenses/>.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +// Expose the Chromebook Pixel lightbar to userspace
> +//
> +// Copyright (C) 2014 Google, Inc.
>
> #define pr_fmt(fmt) "cros_ec_lightbar: " fmt
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 04/12] platform/chrome: cros_ec_sysfs: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 04/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
@ 2019-01-28 19:29 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:29 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also change the description for one more appropriate.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_sysfs.c | 24 +++++-------------------
> 1 file changed, 5 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
> index 0ff5aa30c070..01c420727ee1 100644
> --- a/drivers/platform/chrome/cros_ec_sysfs.c
> +++ b/drivers/platform/chrome/cros_ec_sysfs.c
> @@ -1,21 +1,7 @@
> -/*
> - * cros_ec_sysfs - expose the Chrome OS EC through sysfs
> - *
> - * Copyright (C) 2014 Google, Inc.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program. If not, see <http://www.gnu.org/licenses/>.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +// Expose the ChromeOS EC through sysfs
> +//
> +// Copyright (C) 2014 Google, Inc.
>
> #define pr_fmt(fmt) "cros_ec_sysfs: " fmt
>
> @@ -389,5 +375,5 @@ static struct platform_driver cros_ec_sysfs_driver = {
> module_platform_driver(cros_ec_sysfs_driver);
>
> MODULE_LICENSE("GPL");
> -MODULE_DESCRIPTION("ChromeOS EC control driver");
> +MODULE_DESCRIPTION("Expose the ChromeOS EC through sysfs");
> MODULE_ALIAS("platform:" DRV_NAME);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 05/12] platform/chrome: cros_ec_vbc: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 05/12] platform/chrome: cros_ec_vbc: " Enric Balletbo i Serra
@ 2019-01-28 19:30 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:30 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_vbc.c | 24 +++++-------------------
> 1 file changed, 5 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_vbc.c b/drivers/platform/chrome/cros_ec_vbc.c
> index af9bfe6f385c..8392a1ec33a7 100644
> --- a/drivers/platform/chrome/cros_ec_vbc.c
> +++ b/drivers/platform/chrome/cros_ec_vbc.c
> @@ -1,22 +1,8 @@
> -/*
> - * cros_ec_vbc - Expose the vboot context nvram to userspace
> - *
> - * Copyright (C) 2015 Collabora Ltd.
> - *
> - * based on vendor driver,
> - *
> - * Copyright (C) 2012 The Chromium OS Authors
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +// Expose the vboot context nvram to userspace
> +//
> +// Copyright (C) 2012 Google, Inc.
> +// Copyright (C) 2015 Collabora Ltd.
>
> #include <linux/of.h>
> #include <linux/platform_device.h>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 06/12] platform/chrome: cros_ec_i2c: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 06/12] platform/chrome: cros_ec_i2c: " Enric Balletbo i Serra
@ 2019-01-28 19:31 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:31 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also fix the module license mismatch and change the
> description for a more descriptive phrase.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_i2c.c | 22 ++++++----------------
> 1 file changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_i2c.c b/drivers/platform/chrome/cros_ec_i2c.c
> index 739b985c97e1..691744912dac 100644
> --- a/drivers/platform/chrome/cros_ec_i2c.c
> +++ b/drivers/platform/chrome/cros_ec_i2c.c
> @@ -1,17 +1,7 @@
> -/*
> - * ChromeOS EC multi-function device (I2C)
> - *
> - * Copyright (C) 2012 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
Should be GPL 2.0 only.
> +// I2C interface for ChromeOS Embedded Controller
> +//
> +// Copyright (C) 2012 Google, Inc
>
> #include <linux/acpi.h>
> #include <linux/delay.h>
> @@ -373,5 +363,5 @@ static struct i2c_driver cros_ec_driver = {
>
> module_i2c_driver(cros_ec_driver);
>
> -MODULE_LICENSE("GPL");
> -MODULE_DESCRIPTION("ChromeOS EC multi function device");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("I2C interface for ChromeOS Embedded Controller");
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 07/12] platform/chrome: cros_ec_lpc: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 07/12] platform/chrome: cros_ec_lpc: " Enric Balletbo i Serra
@ 2019-01-28 19:33 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:33 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also remove the license boiler-plate and redundant driver
> description.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_lpc.c | 34 ++++++++---------------
> drivers/platform/chrome/cros_ec_lpc_mec.c | 26 +++--------------
> drivers/platform/chrome/cros_ec_lpc_mec.h | 20 ++-----------
> drivers/platform/chrome/cros_ec_lpc_reg.c | 26 +++--------------
> drivers/platform/chrome/cros_ec_lpc_reg.h | 20 ++-----------
> 5 files changed, 24 insertions(+), 102 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> index 14684a56e40f..c9c240fbe7c6 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -1,25 +1,15 @@
> -/*
> - * cros_ec_lpc - LPC access to the Chrome OS Embedded Controller
> - *
> - * Copyright (C) 2012-2015 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
> - * but everything else (including deghosting) is done here. The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// LPC interface for ChromeOS Embedded Controller
> +//
> +// Copyright (C) 2012-2015 Google, Inc
> +//
> +// This driver uses the ChromeOS EC byte-level message-based protocol for
> +// communicating the keyboard state (which keys are pressed) from a keyboard EC
> +// to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
> +// but everything else (including deghosting) is done here. The main
> +// motivation for this is to keep the EC firmware as simple as possible, since
> +// it cannot be easily upgraded and EC flash/IRAM space is relatively
> +// expensive.
>
> #include <linux/acpi.h>
> #include <linux/dmi.h>
> diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.c b/drivers/platform/chrome/cros_ec_lpc_mec.c
> index c4edfa83e493..296554a82b83 100644
> --- a/drivers/platform/chrome/cros_ec_lpc_mec.c
> +++ b/drivers/platform/chrome/cros_ec_lpc_mec.c
> @@ -1,25 +1,7 @@
> -/*
> - * cros_ec_lpc_mec - LPC variant I/O for Microchip EC
> - *
> - * Copyright (C) 2016 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
> - * but everything else (including deghosting) is done here. The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// LPC variant I/O for Microchip EC
> +//
> +// Copyright (C) 2016 Google, Inc
>
> #include <linux/delay.h>
> #include <linux/io.h>
> diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.h b/drivers/platform/chrome/cros_ec_lpc_mec.h
> index 105068c0e919..68b381f2eb50 100644
> --- a/drivers/platform/chrome/cros_ec_lpc_mec.h
> +++ b/drivers/platform/chrome/cros_ec_lpc_mec.h
> @@ -1,24 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> - * cros_ec_lpc_mec - LPC variant I/O for Microchip EC
> + * LPC variant I/O for Microchip EC
> *
> * Copyright (C) 2016 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
> - * but everything else (including deghosting) is done here. The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
> */
>
> #ifndef __CROS_EC_LPC_MEC_H
> diff --git a/drivers/platform/chrome/cros_ec_lpc_reg.c b/drivers/platform/chrome/cros_ec_lpc_reg.c
> index fc23d535c404..72fc3f6bff90 100644
> --- a/drivers/platform/chrome/cros_ec_lpc_reg.c
> +++ b/drivers/platform/chrome/cros_ec_lpc_reg.c
> @@ -1,25 +1,7 @@
> -/*
> - * cros_ec_lpc_reg - LPC access to the Chrome OS Embedded Controller
> - *
> - * Copyright (C) 2016 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
> - * but everything else (including deghosting) is done here. The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// LPC interface for ChromeOS Embedded Controller
> +//
> +// Copyright (C) 2016 Google, Inc
>
> #include <linux/io.h>
> #include <linux/mfd/cros_ec.h>
> diff --git a/drivers/platform/chrome/cros_ec_lpc_reg.h b/drivers/platform/chrome/cros_ec_lpc_reg.h
> index 1c12c38b306a..416fd2572182 100644
> --- a/drivers/platform/chrome/cros_ec_lpc_reg.h
> +++ b/drivers/platform/chrome/cros_ec_lpc_reg.h
> @@ -1,24 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> - * cros_ec_lpc_reg - LPC access to the Chrome OS Embedded Controller
> + * LPC interface for ChromeOS Embedded Controller
> *
> * Copyright (C) 2016 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
> - * but everything else (including deghosting) is done here. The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
> */
>
> #ifndef __CROS_EC_LPC_REG_H
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 08/12] platform/chrome: cros_ec_proto: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 08/12] platform/chrome: cros_ec_proto: " Enric Balletbo i Serra
@ 2019-01-28 19:33 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:33 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_proto.c | 19 ++++---------------
> 1 file changed, 4 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
> index d2ba662fc713..d259ff264e9d 100644
> --- a/drivers/platform/chrome/cros_ec_proto.c
> +++ b/drivers/platform/chrome/cros_ec_proto.c
> @@ -1,18 +1,7 @@
> -/*
> - * ChromeOS EC communication protocol helper functions
> - *
> - * Copyright (C) 2015 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// ChromeOS EC communication protocol helper functions
> +//
> +// Copyright (C) 2015 Google, Inc
>
> #include <linux/mfd/cros_ec.h>
> #include <linux/delay.h>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 09/12] platform/chrome: cros_ec_spi: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 09/12] platform/chrome: cros_ec_spi: " Enric Balletbo i Serra
@ 2019-01-28 19:34 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:34 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also change the description for one more appropriate.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_spi.c | 20 +++++---------------
> 1 file changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
> index 2be41e8afa47..b20fc4040396 100644
> --- a/drivers/platform/chrome/cros_ec_spi.c
> +++ b/drivers/platform/chrome/cros_ec_spi.c
> @@ -1,17 +1,7 @@
> -/*
> - * ChromeOS EC multi-function device (SPI)
> - *
> - * Copyright (C) 2012 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
GPL-2.0
> +// SPI interface for ChromeOS Embedded Controller
> +//
> +// Copyright (C) 2012 Google, Inc
>
> #include <linux/delay.h>
> #include <linux/kernel.h>
> @@ -730,4 +720,4 @@ static struct spi_driver cros_ec_driver_spi = {
> module_spi_driver(cros_ec_driver_spi);
>
> MODULE_LICENSE("GPL v2");
> -MODULE_DESCRIPTION("ChromeOS EC multi function device (SPI)");
> +MODULE_DESCRIPTION("SPI interface for ChromeOS Embedded Controller");
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 10/12] platform/chrome: cros_kbd_led_backlight: switch to SPDX identifier
2019-01-26 9:51 ` [PATCH v2 10/12] platform/chrome: cros_kbd_led_backlight: " Enric Balletbo i Serra
@ 2019-01-28 19:35 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:35 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also change the term 'Chrome OS' for 'ChromeOS' to be
> coherent with other drivers.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2: None
>
> .../platform/chrome/cros_kbd_led_backlight.c | 19 ++++---------------
> 1 file changed, 4 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/platform/chrome/cros_kbd_led_backlight.c
> index ca3e4da852b4..aa409f0201fb 100644
> --- a/drivers/platform/chrome/cros_kbd_led_backlight.c
> +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c
> @@ -1,18 +1,7 @@
> -/*
> - * Keyboard backlight LED driver for Chrome OS.
> - *
> - * Copyright (C) 2012 Google, Inc.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +// Keyboard backlight LED driver for ChromeOS
> +//
> +// Copyright (C) 2012 Google, Inc.
>
> #include <linux/acpi.h>
> #include <linux/leds.h>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 11/12] platform/chrome: cros_ec_lightbar: remove pr_fmt() define
2019-01-26 9:51 ` [PATCH v2 11/12] platform/chrome: cros_ec_lightbar: remove pr_fmt() define Enric Balletbo i Serra
@ 2019-01-28 19:36 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:36 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> This driver no longer has any pr_{level} messages. Remove the pr_fmt().
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_lightbar.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
> index 37689ad79544..d30a6650b0b5 100644
> --- a/drivers/platform/chrome/cros_ec_lightbar.c
> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
> @@ -3,8 +3,6 @@
> //
> // Copyright (C) 2014 Google, Inc.
>
> -#define pr_fmt(fmt) "cros_ec_lightbar: " fmt
> -
> #include <linux/ctype.h>
> #include <linux/delay.h>
> #include <linux/device.h>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 12/12] platform/chrome: cros_ec_sysfs: remove pr_fmt() define
2019-01-26 9:51 ` [PATCH v2 12/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
@ 2019-01-28 19:36 ` Guenter Roeck
0 siblings, 0 replies; 25+ messages in thread
From: Guenter Roeck @ 2019-01-28 19:36 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Guenter Roeck, Gwendal Grignou, kernel, Benson Leung
On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> This driver no longer has any pr_{level} messages. Remove the pr_fmt().
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v2: None
>
> drivers/platform/chrome/cros_ec_sysfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
> index 01c420727ee1..fe0b7614ae1b 100644
> --- a/drivers/platform/chrome/cros_ec_sysfs.c
> +++ b/drivers/platform/chrome/cros_ec_sysfs.c
> @@ -3,8 +3,6 @@
> //
> // Copyright (C) 2014 Google, Inc.
>
> -#define pr_fmt(fmt) "cros_ec_sysfs: " fmt
> -
> #include <linux/ctype.h>
> #include <linux/delay.h>
> #include <linux/device.h>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2019-01-28 19:37 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-26 9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
2019-01-26 9:51 ` [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier Enric Balletbo i Serra
2019-01-28 19:28 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 02/12] platform/chrome: cros_ec_debugfs: " Enric Balletbo i Serra
2019-01-28 19:28 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 03/12] platform/chrome: cros_ec_lightbar: " Enric Balletbo i Serra
2019-01-28 19:29 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 04/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
2019-01-28 19:29 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 05/12] platform/chrome: cros_ec_vbc: " Enric Balletbo i Serra
2019-01-28 19:30 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 06/12] platform/chrome: cros_ec_i2c: " Enric Balletbo i Serra
2019-01-28 19:31 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 07/12] platform/chrome: cros_ec_lpc: " Enric Balletbo i Serra
2019-01-28 19:33 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 08/12] platform/chrome: cros_ec_proto: " Enric Balletbo i Serra
2019-01-28 19:33 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 09/12] platform/chrome: cros_ec_spi: " Enric Balletbo i Serra
2019-01-28 19:34 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 10/12] platform/chrome: cros_kbd_led_backlight: " Enric Balletbo i Serra
2019-01-28 19:35 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 11/12] platform/chrome: cros_ec_lightbar: remove pr_fmt() define Enric Balletbo i Serra
2019-01-28 19:36 ` Guenter Roeck
2019-01-26 9:51 ` [PATCH v2 12/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
2019-01-28 19:36 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).