From: Nathan Chancellor <natechancellor@gmail.com>
To: GOTO Masanori <gotom@debian.or.jp>,
YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry
Date: Sat, 26 Jan 2019 12:11:43 -0700 [thread overview]
Message-ID: <20190126191143.GB25003@archlinux-ryzen> (raw)
In-Reply-To: <20181210235156.6237-1-natechancellor@gmail.com>
On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of
> variable of type 'unsigned char' to itself [-Wself-assign]
> offset = offset;
> ~~~~~~ ^
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/scsi/nsp32.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> index 5aac3e801903..7ce6e7acf2f3 100644
> --- a/drivers/scsi/nsp32.c
> +++ b/drivers/scsi/nsp32.c
> @@ -2441,7 +2441,6 @@ static void nsp32_set_sync_entry(nsp32_hw_data *data,
>
> period = data->synct[entry].period_num;
> ackwidth = data->synct[entry].ackwidth;
> - offset = offset;
> sample_rate = data->synct[entry].sample_rate;
>
> target->syncreg = TO_SYNCREG(period, offset);
> --
> 2.20.0
>
Ping?
next prev parent reply other threads:[~2019-01-26 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 23:51 [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry Nathan Chancellor
2019-01-26 19:11 ` Nathan Chancellor [this message]
2019-01-27 8:42 ` Masanori Goto
2019-01-28 1:23 ` Nathan Chancellor
2019-01-29 6:27 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190126191143.GB25003@archlinux-ryzen \
--to=natechancellor@gmail.com \
--cc=gotom@debian.or.jp \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yokota@netlab.is.tsukuba.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).