From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34334C282CA for ; Sun, 27 Jan 2019 16:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F371720882 for ; Sun, 27 Jan 2019 16:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548608320; bh=kMn/uz95ZXZ5ajElozqJFkagzkGSNBbvt1JBdF4xUPs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1mzTRFUu3CTERYEOKS0+hJFYS5XWNgiLatD4bqr1SojXfazCdm56n+qO+KktCy8M/ 7q5MIXmG+MCqu0pAx67KXFu+LbXi9FQwgQyMqMaSnAHyM9whGqGrUy9iq3PJ0peAtG KcjlSZYVxxoma1OLsTvT2X9qIHCWISprg8wFZLf8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbfA0Q6d (ORCPT ); Sun, 27 Jan 2019 11:58:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:35452 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726386AbfA0Q6d (ORCPT ); Sun, 27 Jan 2019 11:58:33 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 015E7AF60; Sun, 27 Jan 2019 16:58:30 +0000 (UTC) Date: Sun, 27 Jan 2019 17:58:28 +0100 From: Michal Hocko To: Tetsuo Handa Cc: Arkadiusz =?utf-8?Q?Mi=C5=9Bkiewicz?= , Andrew Morton , Tejun Heo , cgroups@vger.kernel.org, Aleksa Sarai , Jay Kamat , Roman Gushchin , Johannes Weiner , linux-kernel@vger.kernel.org, Linus Torvalds , linux-mm Subject: Re: [PATCH v3] oom, oom_reaper: do not enqueue same task twice Message-ID: <20190127165828.GC18811@dhcp22.suse.cz> References: <6da6ca69-5a6e-a9f6-d091-f89a8488982a@gmail.com> <72aa8863-a534-b8df-6b9e-f69cf4dd5c4d@i-love.sakura.ne.jp> <33a07810-6dbc-36be-5bb6-a279773ccf69@i-love.sakura.ne.jp> <34e97b46-0792-cc66-e0f2-d72576cdec59@i-love.sakura.ne.jp> <2b0c7d6c-c58a-da7d-6f0a-4900694ec2d3@gmail.com> <1d161137-55a5-126f-b47e-b2625bd798ca@i-love.sakura.ne.jp> <20190127083724.GA18811@dhcp22.suse.cz> <20190127114021.GB18811@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 27-01-19 23:57:38, Tetsuo Handa wrote: [...] > >From 9c9e935fc038342c48461aabca666f1b544e32b1 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Sun, 27 Jan 2019 23:51:37 +0900 > Subject: [PATCH v3] oom, oom_reaper: do not enqueue same task twice > > Arkadiusz reported that enabling memcg's group oom killing causes > strange memcg statistics where there is no task in a memcg despite > the number of tasks in that memcg is not 0. It turned out that there > is a bug in wake_oom_reaper() which allows enqueuing same task twice > which makes impossible to decrease the number of tasks in that memcg > due to a refcount leak. > > This bug existed since the OOM reaper became invokable from > task_will_free_mem(current) path in out_of_memory() in Linux 4.7, > but memcg's group oom killing made it easier to trigger this bug by > calling wake_oom_reaper() on the same task from one out_of_memory() > request. > > Fix this bug using an approach used by commit 855b018325737f76 > ("oom, oom_reaper: disable oom_reaper for oom_kill_allocating_task"). > As a side effect of this patch, this patch also avoids enqueuing > multiple threads sharing memory via task_will_free_mem(current) path. > > Signed-off-by: Tetsuo Handa > Reported-by: Arkadiusz Miśkiewicz > Tested-by: Arkadiusz Miśkiewicz > Fixes: af8e15cc85a25315 ("oom, oom_reaper: do not enqueue task if it is on the oom_reaper_list head") Acked-by: Michal Hocko > --- > include/linux/sched/coredump.h | 1 + > mm/oom_kill.c | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h > index ec912d0..ecdc654 100644 > --- a/include/linux/sched/coredump.h > +++ b/include/linux/sched/coredump.h > @@ -71,6 +71,7 @@ static inline int get_dumpable(struct mm_struct *mm) > #define MMF_HUGE_ZERO_PAGE 23 /* mm has ever used the global huge zero page */ > #define MMF_DISABLE_THP 24 /* disable THP for all VMAs */ > #define MMF_OOM_VICTIM 25 /* mm is the oom victim */ > +#define MMF_OOM_REAP_QUEUED 26 /* mm was queued for oom_reaper */ > #define MMF_DISABLE_THP_MASK (1 << MMF_DISABLE_THP) > > #define MMF_INIT_MASK (MMF_DUMPABLE_MASK | MMF_DUMP_FILTER_MASK |\ > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index f0e8cd9..059e617 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -647,8 +647,8 @@ static int oom_reaper(void *unused) > > static void wake_oom_reaper(struct task_struct *tsk) > { > - /* tsk is already queued? */ > - if (tsk == oom_reaper_list || tsk->oom_reaper_list) > + /* mm is already queued? */ > + if (test_and_set_bit(MMF_OOM_REAP_QUEUED, &tsk->signal->oom_mm->flags)) > return; > > get_task_struct(tsk); > -- > 1.8.3.1 -- Michal Hocko SUSE Labs