From: Christoph Hellwig <hch@infradead.org>
To: John Garry <john.garry@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"chenxiang (M)" <chenxiang66@hisilicon.com>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linuxarm@huawei.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, axboe@kernel.dk,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: set rq->cmd_flags with bio->opf instead of data->cmd_flags when bio is not Null
Date: Mon, 28 Jan 2019 07:57:52 -0800 [thread overview]
Message-ID: <20190128155752.GA29076@infradead.org> (raw)
In-Reply-To: <55972c1a-051a-1396-6796-84f349830a35@huawei.com>
On Mon, Jan 28, 2019 at 03:36:58PM +0000, John Garry wrote:
> As I understood, the problem is the scenario of calling
> blk_mq_make_request()->bio_integrity_prep() where we then allocate a bio
> integrity payload in calling bio_integrity_alloc().
>
> In this case, bio_integrity_alloc() sets bio->bi_opf |= REQ_INTEGRITY, which
> is no longer consistent with data.cmd_flags.
I don't see how that could happen:
static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio)
{
...
if (!bio_integrity_prep(bio))
return BLK_QC_T_NONE;
...
data.cmd_flags = bio->bi_opf;
rq = blk_mq_get_request(q, bio, &data);
next prev parent reply other threads:[~2019-01-28 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 13:43 [PATCH] block: set rq->cmd_flags with bio->opf instead of data->cmd_flags when bio is not Null chenxiang
2019-01-25 0:57 ` chenxiang (M)
2019-01-28 14:07 ` Christoph Hellwig
2019-01-28 15:36 ` John Garry
2019-01-28 15:57 ` Christoph Hellwig [this message]
2019-01-28 16:05 ` John Garry
2019-01-29 0:47 ` chenxiang (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128155752.GA29076@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).