From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D51C6C282CD for ; Mon, 28 Jan 2019 16:08:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5B0021738 for ; Mon, 28 Jan 2019 16:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548691709; bh=1GNSsI60a8mvqH9VimS34CW2kW3JPVzBAnvrcVg7Zso=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZUoD4ezQaJQ4A6KGl0QhKLJ18VF3u98RVzikg9rJCh8nS2ZPn1x66UovB46QesBa2 rLM7p+cWUnFExXqh/0FX5Gs5TvNZ1WeJho8YfaKHzd/m/ik7tzTYPFZ0QRhQw8uvyp N6oLEY3F7ZMf/tJQJGz9LMeBDQ1FFFf8nTKhhvbY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732395AbfA1QI1 (ORCPT ); Mon, 28 Jan 2019 11:08:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:60174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730751AbfA1QIZ (ORCPT ); Mon, 28 Jan 2019 11:08:25 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4D4B2147A; Mon, 28 Jan 2019 16:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548691704; bh=1GNSsI60a8mvqH9VimS34CW2kW3JPVzBAnvrcVg7Zso=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HKvSw2ev/bvgCy9qSIR0+AMJt4vuEq2thZImxs6NmxH9yTOkCMyeIjqpU5pxW40rs I4vUA3eaLNJxPRcDtmB7xcI/RKSntey3E0qfqy7tbzf59c3i3aUE8O729/knebmtC5 FaWRbINgBtpn3hT0UFqaVpfg1IOTtceEgoB2NPaw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dave Carroll , Don Brace , "Martin K . Petersen" , Sasha Levin , esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 191/258] scsi: smartpqi: correct volume status Date: Mon, 28 Jan 2019 10:58:17 -0500 Message-Id: <20190128155924.51521-191-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128155924.51521-1-sashal@kernel.org> References: <20190128155924.51521-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Carroll [ Upstream commit 7ff44499bafbd376115f0bb6b578d980f56ee13b ] - fix race condition when a unit is deleted after an RLL, and before we have gotten the LV_STATUS page of the unit. - In this case we will get a standard inquiry, rather than the desired page. This will result in a unit presented which no longer exists. - If we ask for LV_STATUS, insure we get LV_STATUS Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/smartpqi/smartpqi_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 58eb0d31d8d9..3781e8109dd7 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -1184,6 +1184,9 @@ static void pqi_get_volume_status(struct pqi_ctrl_info *ctrl_info, if (rc) goto out; + if (vpd->page_code != CISS_VPD_LV_STATUS) + goto out; + page_length = offsetof(struct ciss_vpd_logical_volume_status, volume_status) + vpd->page_length; if (page_length < sizeof(*vpd)) -- 2.19.1