From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 374C9C282C8 for ; Mon, 28 Jan 2019 17:10:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF50C2175B for ; Mon, 28 Jan 2019 17:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548695406; bh=Cjnvp5qGsnXsNBP0R+FoSvIo9939kgzQkp72htoFvEo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gXqhuEWGwZ1BR8igYvN8C0B951NhFBA5GaNjHSB3D7dVAFHFeM+yNYh3I9BLgIskN ibESvAEoUtNJj8rLWa4biDG+JwCuUWya5dkb0kBLQBKTo15ssTacBAT8mM2YSiamvs YXZk5Pby/PZLLuhFvlD20U0VJV2S6oaWQJYnUksE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387481AbfA1RKE (ORCPT ); Mon, 28 Jan 2019 12:10:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:37850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732020AbfA1QLH (ORCPT ); Mon, 28 Jan 2019 11:11:07 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 898EC2147A; Mon, 28 Jan 2019 16:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548691866; bh=Cjnvp5qGsnXsNBP0R+FoSvIo9939kgzQkp72htoFvEo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=opCct87OSPLeTly5cMJA0Q5yMamttCnAaIrv4nnI3UctVWEwC9jEhbm0bQnZZsl52 2V5Uq5AWc3UGAU2e1WgaRB8Uxvd2PAdkd5Ski32Y1QeD98RNctszXHCa4sAiyxSvi9 8qyg3M0PdG7JGnNupTJB7tlZnPKS2w7GmYdYGJF4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wenwen Wang , Jens Axboe , Sasha Levin Subject: [PATCH AUTOSEL 4.19 241/258] gdrom: fix a memory leak bug Date: Mon, 28 Jan 2019 10:59:07 -0500 Message-Id: <20190128155924.51521-241-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128155924.51521-1-sashal@kernel.org> References: <20190128155924.51521-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang [ Upstream commit 093c48213ee37c3c3ff1cf5ac1aa2a9d8bc66017 ] In probe_gdrom(), the buffer pointed by 'gd.cd_info' is allocated through kzalloc() and is used to hold the information of the gdrom device. To register and unregister the device, the pointer 'gd.cd_info' is passed to the functions register_cdrom() and unregister_cdrom(), respectively. However, this buffer is not freed after it is used, which can cause a memory leak bug. This patch simply frees the buffer 'gd.cd_info' in exit_gdrom() to fix the above issue. Signed-off-by: Wenwen Wang Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/cdrom/gdrom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c index ae3a7537cf0f..72cd96a8eb19 100644 --- a/drivers/cdrom/gdrom.c +++ b/drivers/cdrom/gdrom.c @@ -889,6 +889,7 @@ static void __exit exit_gdrom(void) platform_device_unregister(pd); platform_driver_unregister(&gdrom_driver); kfree(gd.toc); + kfree(gd.cd_info); } module_init(init_gdrom); -- 2.19.1