From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"colyli@suse.de" <colyli@suse.de>,
"ckeepax@opensource.wolfsonmicro.com"
<ckeepax@opensource.wolfsonmicro.com>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"xiaotong.lu@spreadtrum.com" <xiaotong.lu@spreadtrum.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/4] dt-bindings: input: Add documentation for gp2a sensor
Date: Mon, 28 Jan 2019 11:30:02 -0800 [thread overview]
Message-ID: <20190128193002.GE34692@dtor-ws> (raw)
In-Reply-To: <BYAPR02MB54959FD8A7CF5977B0D4B5B7A3940@BYAPR02MB5495.namprd02.prod.outlook.com>
On Sat, Jan 26, 2019 at 03:14:14AM +0000, Jonathan Bakker wrote:
> Hi Dmitry,
>
> Thanks for your review of the patches.
>
> Considering that the light sensor part should be in IIO, should the entire driver be rewritten as an IIO driver? There's already the driver for gp2ap020a00f there which is presumably the gp2ap002a00f's successor and does the same functions.
I'd be fine with that.
>
> On 2019-01-25 5:32 p.m., Dmitry Torokhov wrote:
> > On Fri, Jan 25, 2019 at 06:50:45PM +0100, Paweł Chmiel wrote:
> >> From: Jonathan Bakker <xc-racer2@live.ca>
> >>
> >> This commit adds documentation for Sharp GP2AP002A00F.
> >> It's Proximity/Opto Sensor connected over i2c.
> >>
> >> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> >> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> >> ---
> >> .../bindings/input/sharp,gp2ap002a00f.txt | 29 +++++++++++++++++++
> >> 1 file changed, 29 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/input/sharp,gp2ap002a00f.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/input/sharp,gp2ap002a00f.txt b/Documentation/devicetree/bindings/input/sharp,gp2ap002a00f.txt
> >> new file mode 100644
> >> index 000000000000..c524eb7d3d60
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/input/sharp,gp2ap002a00f.txt
> >> @@ -0,0 +1,29 @@
> >> +* Sharp GP2AP002A00F I2C Proximity/Opto Sensor
> >> +
> >> +Required properties:
> >> +- compatible : Should be "sharp,gp2ap002a00f"
> >> +- reg : The I2C address of the sensor
> >> +- vout-gpio : The gpio connected to the vout pin
> >
> > Do you know what it is for?
> >
> It's the control of the main power supply to the chip.
In this case it should be a power supply (regulator), not gpio.
Thanks.
--
Dmitry
prev parent reply other threads:[~2019-01-28 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 17:50 [PATCH 0/4] input: misc: gp2a: Add device tree support Paweł Chmiel
2019-01-25 17:50 ` [PATCH 1/4] input: misc: gp2a: Use managed resource helpers Paweł Chmiel
2019-01-26 1:17 ` Dmitry Torokhov
2019-01-25 17:50 ` [PATCH 2/4] input: misc: gp2a: Add support for light sensor Paweł Chmiel
2019-01-26 1:18 ` Dmitry Torokhov
2019-01-25 17:50 ` [PATCH 3/4] input: misc: gp2a: Enable device tree Paweł Chmiel
2019-01-25 17:50 ` [PATCH 4/4] dt-bindings: input: Add documentation for gp2a sensor Paweł Chmiel
2019-01-26 1:32 ` Dmitry Torokhov
2019-01-26 3:14 ` Jonathan Bakker
2019-01-28 19:30 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128193002.GE34692@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andrew.smirnov@gmail.com \
--cc=arnd@arndb.de \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=colyli@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=xc-racer2@live.ca \
--cc=xiaotong.lu@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).